public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Richard Palethorpe <rpalethorpe@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] Refactor getdtablesize01 using new LTP API
Date: Tue, 31 Oct 2023 18:11:13 +0100	[thread overview]
Message-ID: <ZUE1MWuiU63iK3IU@yuki> (raw)
In-Reply-To: <87edhrvx3r.fsf@suse.de>

Hi!
> > +static void setup(void)
> >  {
> > +	int fd;
> > +
> > +	fd = SAFE_CREAT(FILENAME, 0644);
> > +	SAFE_CLOSE(fd);
> >  }
> > +
> > +static struct tst_test test = {
> > +	.test_all = run,
> > +	.setup = setup,
> > +	.needs_tmpdir = 1,
> 
> This tests the underlying file system to some extent, so we should test
> all available file systems.

As far as I can tell it does not actually. This is a compatibility
function for od unixes and the name is literrally 'get descriptor table
size' so I suppose that it once returned the size of the array allocated
for the process to store file descritptors into.

So I supose that the only sensible approach is to call the function and
check that it returns a sane value.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2023-10-31 17:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11  9:40 [LTP] [PATCH v1] Refactor getdtablesize01 using new LTP API Andrea Cervesato
2023-10-19  7:53 ` Richard Palethorpe
2023-10-31 17:11   ` Cyril Hrubis [this message]
2023-11-01  8:01     ` Richard Palethorpe
2023-11-16 14:43   ` Andrea Cervesato via ltp
2023-11-17  8:51     ` Richard Palethorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZUE1MWuiU63iK3IU@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=rpalethorpe@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox