From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32D04C4332F for ; Tue, 31 Oct 2023 17:10:57 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 186153CE9F9 for ; Tue, 31 Oct 2023 18:10:55 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id C47033CC972 for ; Tue, 31 Oct 2023 18:10:44 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id C15431001848 for ; Tue, 31 Oct 2023 18:10:42 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 728672184E; Tue, 31 Oct 2023 17:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1698772242; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5m23MEPye/MoiI29K2aZVnwtkmkkfULMbulYSCQfVuE=; b=m2mPE1gEGUmAL/AUP17Z38jxAh7kj9ec1JCkw8FCIPmQTBXQPsaBJIclObMyGO0M00VZyn mW5r5kbpnf4dh4kuDocD+C7ZAWREcEuoWVgHqo+vrUccaAiPX6ja3jNGPyp4IRkNBWz3d3 pQSF/QBhwC64CEjuY8kPK1NQzXuseDw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1698772242; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5m23MEPye/MoiI29K2aZVnwtkmkkfULMbulYSCQfVuE=; b=ysaVGzEfTRBrrwqR12XN8Nl02Xlrs9eIAEjfYJIQyouE+KurUqvqSeoYhnUAuK/ynJrMLe li4p20kDdNughzBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5F3C11391B; Tue, 31 Oct 2023 17:10:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dPTDFRI1QWWjagAAMHmgww (envelope-from ); Tue, 31 Oct 2023 17:10:42 +0000 Date: Tue, 31 Oct 2023 18:11:13 +0100 From: Cyril Hrubis To: Richard Palethorpe Message-ID: References: <20230911094043.25511-1-andrea.cervesato@suse.de> <87edhrvx3r.fsf@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87edhrvx3r.fsf@suse.de> X-Virus-Scanned: clamav-milter 1.0.1 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v1] Refactor getdtablesize01 using new LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > +static void setup(void) > > { > > + int fd; > > + > > + fd = SAFE_CREAT(FILENAME, 0644); > > + SAFE_CLOSE(fd); > > } > > + > > +static struct tst_test test = { > > + .test_all = run, > > + .setup = setup, > > + .needs_tmpdir = 1, > > This tests the underlying file system to some extent, so we should test > all available file systems. As far as I can tell it does not actually. This is a compatibility function for od unixes and the name is literrally 'get descriptor table size' so I suppose that it once returned the size of the array allocated for the process to store file descritptors into. So I supose that the only sensible approach is to call the function and check that it returns a sane value. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp