Re: [LTP] [PATCH 2/4] lib: Add .modprobe

Cyril Hrubis
2023-11-03T12:20:55Z

Hi!
> Yes, but see safe_cmd() in lib/tst_safe_macros.c. tst_cmd() is called with
> TST_CMD_PASS_RETVAL | TST_CMD_TCONF_ON_MISSING, thus this is covered.

TCONF_ON_MISSING means to TCONF when the command is missing, i.e. if
modprobe is not installed on the system. When module is missing modprobe
will return 1 so I suppose we have to handle the return value from the
TST_CMD() or do I missing something?

> > modprobe -r please, rmmod has been deprecated for ages.
>
> Ah, here goes the reason. Should it be replaced also in tst_module_unload_()?

Yes please.

--
Cyril Hrubis
chrubis@suse.cz