From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] Refactor fork09 using new LTP API
Date: Thu, 2 Nov 2023 13:52:03 +0100 [thread overview]
Message-ID: <ZUObc261T47VHVJp@yuki> (raw)
In-Reply-To: <ZUJydZgdGTcPQAxt@yuki>
Hi!
> Honestly I'm struggling to understand the point of this test, the
> description says:
>
> "Check that child has access to a full set of files"
>
> What is that supposed to mean? I guess that if we wanted to check that
> the child has inherited the file descriptors ee should open a few files,
> do some changes in the child/parent and check that they are not propagated to
> the other one. I.e. reading from a file in child/parent does not change
> file offset in parent. Closing a file descriptor from a child/parent
And I tend to forget that the file offset is shared between child and
parent in this case. Maybe it's because I want to forget about that
particular detail to begin with.
And the test fork10.c actually checks the offset case, so I have no idea
what to do with fork09.c test. Maybe we should just delete the test and
write new for something that is not currently tested, there is plenty of
Linux-specific behavior listed in fork(2) man page that is not tested at
all...
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-11-02 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 15:05 [LTP] [PATCH v1] Refactor fork09 using new LTP API Andrea Cervesato
2023-11-01 15:44 ` Cyril Hrubis
2023-11-02 12:52 ` Cyril Hrubis [this message]
2023-11-02 12:56 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUObc261T47VHVJp@yuki \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox