From: Cyril Hrubis <chrubis@suse.cz>
To: Edward Liaw <edliaw@google.com>
Cc: kernel-team@android.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] madvise11: Allow test to skip if MADV_SOFT_OFFLINE is not supported
Date: Fri, 3 Nov 2023 11:47:57 +0100 [thread overview]
Message-ID: <ZUTP3YcexuyOd3ye@yuki> (raw)
In-Reply-To: <20231102230054.3195864-1-edliaw@google.com>
Hi!
> madvise11 will exit with TFAIL if CONFIG_MEMORY_FAILURE is not
> configured. Skip the TFAIL if EINVAL is returned by madvise.
Does it make sense to keep the test running if the config option is not
present? As far as I can tell we are trying to reproduce a race there
that depends on the madvise being able to soft offline the pages.
What about this then?
diff --git a/testcases/kernel/syscalls/madvise/madvise11.c b/testcases/kernel/syscalls/madvise/madvise11.c
index 74caadc44..50ab935c9 100644
--- a/testcases/kernel/syscalls/madvise/madvise11.c
+++ b/testcases/kernel/syscalls/madvise/madvise11.c
@@ -426,6 +426,10 @@ static struct tst_test test = {
"rmmod",
NULL
},
+ .needs_kconfigs = (const char *[]) {
+ "CONFIG_MEMORY_FAILURE=y",
+ NULL
+ },
.max_runtime = 30,
.needs_checkpoints = 1,
.setup = setup,
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-11-03 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 23:00 [LTP] [PATCH] madvise11: Allow test to skip if MADV_SOFT_OFFLINE is not supported Edward Liaw via ltp
2023-11-02 23:00 ` [LTP] [PATCH] madvise11: Replace /etc/mtab with /proc/mounts Edward Liaw via ltp
2023-11-03 8:29 ` Petr Vorel
2023-11-03 8:38 ` Petr Vorel
2023-11-03 10:47 ` Cyril Hrubis [this message]
2023-11-03 15:54 ` [LTP] [PATCH] madvise11: Allow test to skip if MADV_SOFT_OFFLINE is not supported Edward Liaw via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUTP3YcexuyOd3ye@yuki \
--to=chrubis@suse.cz \
--cc=edliaw@google.com \
--cc=kernel-team@android.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox