From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAC09C4167B for ; Thu, 7 Dec 2023 12:26:08 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 076793CBBE6 for ; Thu, 7 Dec 2023 13:26:07 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id E74503CA6DE for ; Thu, 7 Dec 2023 13:25:56 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id C510C1001596 for ; Thu, 7 Dec 2023 13:25:55 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6C0DD22092; Thu, 7 Dec 2023 12:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1701951953; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2NqadJHYq8xvZ6Y/VMmGn/8sq6ZOXu16/5qillee97E=; b=G+/Odopvh1NCHvMARCfwhpQrB8hrOsKz3kum1i026qZjayJyC+jY87de4kifB5zLPE/HZa 7L5veFkY4mj0pR/R51FxPIlmbUfgq7Xr9SghtKpVXKspFJv5gcicv10DgTLAzRTjAbbPSK 27rszIASCVrkvUTntV923/7L6Oedre8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1701951953; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2NqadJHYq8xvZ6Y/VMmGn/8sq6ZOXu16/5qillee97E=; b=5CSa3rkj9lUaF7wbIV0V6A/NpXeZSnz89XqvIC/BocxRAjos3XMpCacN+W6762ePawrfR6 EqyUjCsQRBOAG9CA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 24DC413B6A; Thu, 7 Dec 2023 12:25:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id CdjcBtG5cWX6CQAAD6G6ig (envelope-from ); Thu, 07 Dec 2023 12:25:53 +0000 Date: Thu, 7 Dec 2023 13:25:43 +0100 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20231207111223.234170-1-pvorel@suse.cz> <20231207111844.GA234785@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-0.80 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.00)[30.49%] X-Virus-Scanned: clamav-milter 1.0.1 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 1/1] fsx-linux: Reduce log output X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > more than TVERB, it would be nice to add a "verbose_flag". Something like: > > tst_res(TINFO, "my message %s", my_param, verbose_flag) That's technically impossible, because the printf() like messages have variable number of parameters. Also it's really hard to extend the API at this point without really breaking it. We would have to also rewrite a few thousands of test if we introduce such change, which may be possible with coccinelle, but I would rather avoid such hassle. > And then with a -v we filter out messages which are verbose or not. > In this way we don't add T-flags and we can handle any kind of messages > in verbose mode. If you are worried about the output, we can easily produce TINFO messages for the TVERB flag too. Or possibly name the flags as TINFO with a debug level appended e.g. we can add TINFO0, TINFO1 and TINFO2 and define TINFO to TNFO0 for backwards compatibility. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp