From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C111C4167B for ; Thu, 7 Dec 2023 14:34:06 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id A4F3C3CD8A9 for ; Thu, 7 Dec 2023 15:34:04 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 9BF983C6A7A for ; Thu, 7 Dec 2023 15:33:53 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 4E3B2204725 for ; Thu, 7 Dec 2023 15:33:51 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BA6651FB68; Thu, 7 Dec 2023 14:33:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1701959630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cbIILpPU4O/CYPufSjDFVOBlCYtDBe0oPyyPwYROY+Y=; b=J+g5oDVMHGtAEl6TLGLUDijX542rgs/u1O/sUgB1ynFgEEdqUzn1rN5bxGWeD+19uEhe8i CXArRC2WppxAgQ8YocYbAvL3XcK4CfpVO5nCL2QIAKBANid8JHMaR7dVSGJPgWEm8panQr x4b/D0JAXQQXTowet4W0itA1zXX/NgU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1701959630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cbIILpPU4O/CYPufSjDFVOBlCYtDBe0oPyyPwYROY+Y=; b=vVt9mI3o80FYF2dxYM/8KQ/Hc6xQvJNzBbWdaEqVDfqyq/bIqPzP4hPTKU5WwbMyJd9gh2 sqJ9jp38bk29R2DA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1701959630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cbIILpPU4O/CYPufSjDFVOBlCYtDBe0oPyyPwYROY+Y=; b=J+g5oDVMHGtAEl6TLGLUDijX542rgs/u1O/sUgB1ynFgEEdqUzn1rN5bxGWeD+19uEhe8i CXArRC2WppxAgQ8YocYbAvL3XcK4CfpVO5nCL2QIAKBANid8JHMaR7dVSGJPgWEm8panQr x4b/D0JAXQQXTowet4W0itA1zXX/NgU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1701959630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cbIILpPU4O/CYPufSjDFVOBlCYtDBe0oPyyPwYROY+Y=; b=vVt9mI3o80FYF2dxYM/8KQ/Hc6xQvJNzBbWdaEqVDfqyq/bIqPzP4hPTKU5WwbMyJd9gh2 sqJ9jp38bk29R2DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9332113B6A; Thu, 7 Dec 2023 14:33:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id 6eQuIc7XcWV0NwAAD6G6ig (envelope-from ); Thu, 07 Dec 2023 14:33:50 +0000 Date: Thu, 7 Dec 2023 15:33:40 +0100 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20231116135546.2599273-1-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231116135546.2599273-1-pvorel@suse.cz> Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-0.80 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_SEVEN(0.00)[11]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.00)[36.00%] X-Virus-Scanned: clamav-milter 1.0.1 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 1/1] lib: Add support bcachefs filesystem X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kent Overstreet , Brian Foster , fstests@vger.kernel.org, linux-bcachefs@vger.kernel.org, Richard Palethorpe , ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > bcachefs has been merged into v6.7-rc1 [1]. Let's add it's support to > LTP .all_filesystems = 1 and TST_ALL_FILESYSTEMS=1. > > [1] https://lwn.net/Articles/934692/ > > Suggested-by: Cyril Hrubis > Signed-off-by: Petr Vorel > --- > Hi, > > this should be merged after v6.7 is released. Agreed, although it's unlikey that they will pull bcachefs off from the tree now. Any way I think that we should add the support to the next release. > So far I haven't tested all LTP tests on bcachefs temporary directory. > I have only tested tests which use .all_filesystems = 1 or TST_ALL_FILESYSTEMS=1. > So far it looks like there are only a few tests failing: > > statvfs01.c:44: TFAIL: creat(valid_fname, 0444) failed: ENAMETOOLONG (36) That strange, that would mean that statvfs() reports possibly wrong f_namemax. Looking at the code the f_namemax is initialized to BCH_NAME_MAX in bch2_statfs(). And the dirent_create_key() does: if (name->len > BCH_NAME_MAX) return ERR_PTR(-ENAMETOOLONG); That does not look like there is any room for a failure. Maybe we can print the buf.f_namemax value in the test and check if it's 512 since that is the value of BCH_NAME_MAX. > statx04.c:122: TFAIL: STATX_ATTR_COMPRESSED not supported This probably just needs: diff --git a/testcases/kernel/syscalls/statx/statx04.c b/testcases/kernel/syscalls/statx/statx04.c index 58296bd24..8d14cef8c 100644 --- a/testcases/kernel/syscalls/statx/statx04.c +++ b/testcases/kernel/syscalls/statx/statx04.c @@ -97,7 +97,8 @@ static void setup(void) expected_mask |= attr_list[i].attr; /* STATX_ATTR_COMPRESSED not supported on XFS, TMPFS */ - if (!strcmp(tst_device->fs_type, "xfs") || !strcmp(tst_device->fs_type, "tmpfs")) + if (!strcmp(tst_device->fs_type, "xfs") || !strcmp(tst_device->fs_type, "tmpfs") || + !strcmp(tst_device->fs_type, "bcachefs") expected_mask &= ~STATX_ATTR_COMPRESSED; /* Attribute support was added to Btrfs statx() in kernel v4.13 */ > fanotify13.c, fanotify15.c and fanotify16.c produce many errors. That is probably something for Jan Kara or Amir Goldstein. > I haven't tested on machine with more NUMA nodes, thus > set_mempolicy03.c, set_mempolicy04.c has not been tested. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp