From: Cyril Hrubis <chrubis@suse.cz>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-bcachefs@vger.kernel.org, Brian Foster <bfoster@redhat.com>,
fstests@vger.kernel.org, Jan Kara <jack@suse.cz>,
Richard Palethorpe <rpalethorpe@suse.com>,
ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 3/3] statx04: Skip STATX_ATTR_COMPRESSED on Bcachefs
Date: Tue, 9 Jan 2024 11:32:24 +0100 [thread overview]
Message-ID: <ZZ0guBd48WXYapPL@yuki> (raw)
In-Reply-To: <gjfjylr4bdytdot7ywjispswvgpvjtkdmtsinsbcbc42ik2y3d@ws4tjmwqywrb>
Hi!
> > Quite likely, other filesystems does have an inode flag that is set when
> > file has been compressed and simply report that in the foo_getattr()
> > callback. Looking at bcachefs I supose that we need to figure out if the
> > inode is v3 and then unpack the v3 info to get to the compressed flag,
> > you probably know best how to do that.
>
> I'm still not clear how we want to map STATX_ATTR_COMPRESSED, since it's
> extents that are compressed, not entire files - and just reporting the
> compression option is probably not what we want since it can be flipped
> off, and existing data will still be compressed.
>
> Do you know anything about the intended use case?
As far as I understand the flag it's a hint that the file I/O may be
slower/need more memory because of the compression.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-01-09 10:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 19:40 [LTP] [PATCH v2 0/3] Add support bcachefs filesystem Petr Vorel
2023-12-07 19:40 ` [LTP] [PATCH v2 1/3] lib: Add Bcachefs magic Petr Vorel
2024-01-12 13:18 ` Su Yue
2024-01-12 13:58 ` Petr Vorel
2023-12-07 19:40 ` [LTP] [PATCH v2 2/3] lib: Add support bcachefs filesystem to .all_filesystems Petr Vorel
2023-12-07 19:40 ` [LTP] [PATCH v2 3/3] statx04: Skip STATX_ATTR_COMPRESSED on Bcachefs Petr Vorel
[not found] ` <20231213024617.vx3epsav2n2lxozi@moria.home.lan>
2024-01-04 3:32 ` Li Wang
2024-01-08 10:01 ` Cyril Hrubis
2024-01-08 20:54 ` Kent Overstreet
2024-01-09 10:32 ` Cyril Hrubis [this message]
2024-04-19 13:11 ` Cyril Hrubis
2024-05-07 8:18 ` Petr Vorel
2024-05-07 14:16 ` Kent Overstreet
2024-05-07 17:03 ` Petr Vorel
2023-12-12 14:48 ` [LTP] [PATCH v2 0/3] Add support bcachefs filesystem Jan Kara
2023-12-13 16:51 ` Jan Kara
2024-01-08 10:14 ` Cyril Hrubis
2024-01-08 20:04 ` Petr Vorel
2024-01-11 14:05 ` [LTP] ENODEV on bcachefs on kernel < 6.7 [was: Re: [PATCH v2 0/3] Add support bcachefs filesystem] pvorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZ0guBd48WXYapPL@yuki \
--to=chrubis@suse.cz \
--cc=bfoster@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=jack@suse.cz \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox