From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] getcwd01: Implement .test_variants
Date: Wed, 3 Jan 2024 09:21:25 +0100 [thread overview]
Message-ID: <ZZUZBfdTGaQ7huVg@rei> (raw)
In-Reply-To: <20231227144839.GB757946@pevik>
Hi!
> @Li @Cyril: are you ok to test libc getcwd() wrapper implementations on NULL
> buffer in getcwd01.c? Or we just skip NULL buffer test on all libc?
> I would be ok to test it, because change in the implementation can influence
> lots of user space software, although glibc or any other libc can obviously
> change it's behavior.
I guess that the easiest solution is to run the test in a child and pass
the test both on EFAULT and child being killed by SIGSEGV. Any special
cases and ifdefs are assuming something that is not promised and will
have to be changed sooner or later.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-01-03 8:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 10:53 [LTP] [PATCH v1] getcwd01: Implement .test_variants Wei Gao via ltp
2023-12-15 19:47 ` Petr Vorel
2023-12-22 10:06 ` [LTP] [PATCH v2] " Wei Gao via ltp
2023-12-27 13:21 ` Petr Vorel
2023-12-27 14:48 ` Petr Vorel
2024-01-03 8:21 ` Cyril Hrubis [this message]
2024-01-03 8:44 ` Petr Vorel
2024-01-03 9:32 ` Wei Gao via ltp
2024-01-04 2:23 ` Wei Gao via ltp
2024-01-03 8:39 ` Wei Gao via ltp
2024-01-03 8:48 ` Petr Vorel
2024-01-04 2:40 ` [LTP] [PATCH v3] " Wei Gao via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZUZBfdTGaQ7huVg@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox