Re: [LTP] [PATCH v2] ioctl_fiemap01: New test for fiemap ioctl()

Petr Vorel
2024-03-29T21:33:04Z

Hi Wei,

...
> > > + fiemap->fm_flags = -1;
> > > + TST_EXP_FAIL(ioctl(fd, FS_IOC_FIEMAP, fiemap), EBADR);

> > I get on Tumbleweed with 6.8.0-rc4-1.g9b23bf2-default EOPNOTSUPP:
> > ioctl_fiemap01.c:52: TFAIL: ioctl(fd, FS_IOC_FIEMAP, fiemap) expected EBADR: EOPNOTSUPP (95)
> > What is the missing dependency for FS_IOC_FIEMAP? Or is there wrong fiemap use
> > which causes that?
> Thanks for your test and i also reproduce this issue.
> This is caused by Tumbleweed mount tmpfs on /tmp and tmpfs seems not support fiemap action.
> tmpfs on /tmp type tmpfs (rw,nosuid,nodev,size=494452k,nr_inodes=1048576,inode64)

+1. You probably knows that you need .skip_filesystems, which works even
.all_filesystems is not set.

.skip_filesystems = (const char *const []) {
"tmpfs",
NULL
},

But actually when this is filesystem dependent, I guess .all_filesystems = 1
would make sense, right?

> I will sent new patch for cover all supported filesystem.

I suppose you agree :).

Kind regards,
Petr