Re: [LTP] [PATCH v3] ioctl_fiemap01: New test for fiemap ioctl()

Petr Vorel
2024-04-15T12:18:06Z

> On Wed, Apr 03, 2024 at 11:28:27AM +0200, Petr Vorel wrote:
> > Hi Wei,

> > > +static struct tst_test test = {
> > > + .mount_device = 1,
> > > + .mntpoint = TMPDIR,
> > > + .all_filesystems = 1,
> > > + .skip_filesystems = (const char *const[]) {
> > > + "exfat", "vfat", "fuse", "ntfs", "tmpfs", NULL

> > Why do you whitelist fuse? Which filesystem under fuse does not work?
> I will remove fuse in next patch.

> But i find fs_type_whitelist not contain "fuse", so this will lead

lib/tst_supported_fs_types.c contains:

skip_fuse = tst_fs_in_skiplist("fuse", skiplist);

=> please use it.

Kind regards,
Petr

> func tst_get_supported_fs_type can not handle "fuse" filesystem,
> means add/remove "fuse" into skip_filesystems will not take any effect.
> Correct me if i have any misunderstanding.

> static const char *const fs_type_whitelist[] = {
> "ext2",
> "ext3",
> "ext4",
> "xfs",
> "btrfs",
> "bcachefs",
> "vfat",
> "exfat",
> "ntfs",
> "tmpfs",
> NULL
> };