public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: Martin Doucha <martin.doucha@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 1/4] lib: Add tst_fd iterator
Date: Tue, 16 Jan 2024 16:19:02 +0100	[thread overview]
Message-ID: <ZaaeZmg8mi2dWVPn@yuki> (raw)
In-Reply-To: <20240116003219.GD2535088@pevik>

Hi!
> In file included from ../include/lapi/io_uring.h:17:0,
>                  from tst_fd.c:21:
> /usr/include/sys/mount.h:35:3: error: expected identifier before numeric constant
>    MS_RDONLY = 1,  /* Mount read-only.  */
>    ^

Looks like the best solution for now is:

diff --git a/include/lapi/io_uring.h b/include/lapi/io_uring.h
index a63741a08..03c45190e 100644
--- a/include/lapi/io_uring.h
+++ b/include/lapi/io_uring.h
@@ -14,7 +14,6 @@
 #include <sys/types.h>
 #include <sys/uio.h>
 #include <stdlib.h>
-#include <linux/fs.h>

 #include "lapi/syscalls.h"


As far as I can tell the only reason this header is included is the
__kernel_rwf_t definition which has a fallback definition just a few
lines below.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-01-16 15:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 12:53 [LTP] [PATCH v3 0/4] Add tst_fd iterator API Cyril Hrubis
2024-01-15 12:53 ` [LTP] [PATCH v3 1/4] lib: Add tst_fd iterator Cyril Hrubis
2024-01-15 23:09   ` Petr Vorel
2024-01-16  0:32     ` Petr Vorel
2024-01-16 15:19       ` Cyril Hrubis [this message]
2024-01-16 15:31         ` Petr Vorel
2024-01-17 15:38           ` Cyril Hrubis
2024-01-15 12:53 ` [LTP] [PATCH v3 2/4] syscalls: readahead01: Make use of tst_fd Cyril Hrubis
2024-01-15 23:16   ` Petr Vorel
2024-01-17 14:49   ` Jan Kara
2024-01-15 12:53 ` [LTP] [PATCH v3 3/4] syscalls: accept: Add tst_fd test Cyril Hrubis
2024-01-15 23:22   ` Petr Vorel
2024-01-17 14:49   ` Jan Kara
2024-01-15 12:53 ` [LTP] [PATCH v3 4/4] syscalls: splice07: New splice tst_fd iterator test Cyril Hrubis
2024-01-17 14:50   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZaaeZmg8mi2dWVPn@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=martin.doucha@suse.com \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox