From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CBEAC46CD2 for ; Wed, 24 Jan 2024 10:57:26 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 9F2463CFA8C for ; Wed, 24 Jan 2024 11:57:24 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id E31293CAB0C for ; Wed, 24 Jan 2024 11:57:08 +0100 (CET) Authentication-Results: in-4.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=2a07:de40:b251:101:10:150:64:1; helo=smtp-out1.suse.de; envelope-from=chrubis@suse.cz; receiver=lists.linux.it) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id DDE1E1015435 for ; Wed, 24 Jan 2024 11:57:07 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D84C522040; Wed, 24 Jan 2024 10:57:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706093826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jGXFxQTIMgS/fW9AW750/9kFWiH+dTdduMZKaD4gJSo=; b=UYkihTysIGMyA96hndYvEqM3x2V4WJQWIU1vdokCwhZ/T6f01sb49KbtqHp9TWTYYoSUE0 d3LnUrIuYoQXPARcf1QrRh8oZBzmOZPn+wL6CeP2vO+XbTEgaWhUtqiMznHvHocUeCab/M 6zw3VAoEERtJ6JcLIeU1dfUcvbMpinY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706093826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jGXFxQTIMgS/fW9AW750/9kFWiH+dTdduMZKaD4gJSo=; b=E4glXsQOzC+nX/CCXAB3m7lUBv9x1J4gTFSPSTDuxlkCP3upYDQnFeUDxOJGAmUQm+5eSS cOXhyiZSVQ4mXgAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706093826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jGXFxQTIMgS/fW9AW750/9kFWiH+dTdduMZKaD4gJSo=; b=UYkihTysIGMyA96hndYvEqM3x2V4WJQWIU1vdokCwhZ/T6f01sb49KbtqHp9TWTYYoSUE0 d3LnUrIuYoQXPARcf1QrRh8oZBzmOZPn+wL6CeP2vO+XbTEgaWhUtqiMznHvHocUeCab/M 6zw3VAoEERtJ6JcLIeU1dfUcvbMpinY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706093826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jGXFxQTIMgS/fW9AW750/9kFWiH+dTdduMZKaD4gJSo=; b=E4glXsQOzC+nX/CCXAB3m7lUBv9x1J4gTFSPSTDuxlkCP3upYDQnFeUDxOJGAmUQm+5eSS cOXhyiZSVQ4mXgAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C0BCE13786; Wed, 24 Jan 2024 10:57:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +nUsLQLtsGViFQAAD6G6ig (envelope-from ); Wed, 24 Jan 2024 10:57:06 +0000 Date: Wed, 24 Jan 2024 11:57:19 +0100 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20240123162647.210424-1-pvorel@suse.cz> <20240123162647.210424-4-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240123162647.210424-4-pvorel@suse.cz> Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-3.60 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.00)[25.62%] X-Virus-Scanned: clamav-milter 1.0.3 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 3/4] kernel: Fix tst_brk TFAIL X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > diff --git a/testcases/kernel/device-drivers/zram/zram01.sh b/testcases/kernel/device-drivers/zram/zram01.sh > index 6bc305f2c..234bf06dd 100755 > --- a/testcases/kernel/device-drivers/zram/zram01.sh > +++ b/testcases/kernel/device-drivers/zram/zram01.sh > @@ -82,7 +82,8 @@ zram_makefs() > mkfs.$fs /dev/zram$i > err.log 2>&1 > if [ $? -ne 0 ]; then > cat err.log > - tst_brk TFAIL "failed to make $fs on /dev/zram$i" > + tst_res TFAIL "failed to make $fs on /dev/zram$i" > + return I do not think that this one is correct, unlike other tests the steps in zram depends on each other if this fails and we attempt to continue we will get failues from zram_mount and zram_fill_fs as well. The zram tests are unfortunatelly messy in a sense that a testcase is a setup for the next one so we really need to exit the whole test if one of the testcases fails. I guess the clearest solution would be TFAIL followed by a TBROK in this case. Something as: tst_res TFAIL "Failed to make $fs on /dev/zram$i" tst_brk TBROK "Can't continue with mounting the FS" > diff --git a/testcases/kernel/security/integrity/ima/tests/ima_tpm.sh b/testcases/kernel/security/integrity/ima/tests/ima_tpm.sh > index b675a20a1..2a28562e6 100755 > --- a/testcases/kernel/security/integrity/ima/tests/ima_tpm.sh > +++ b/testcases/kernel/security/integrity/ima/tests/ima_tpm.sh > @@ -159,7 +159,8 @@ get_pcr10_aggregate() > $cmd > hash.txt 2>&1 > ret=$? > elif [ $ret -ne 0 -a "$MISSING_EVMCTL" = 1 ]; then > - tst_brk TFAIL "evmctl failed $msg" > + tst_res TFAIL "evmctl failed $msg" > + return > fi Again here, I'm not sure if it's safe to continue with the rest of the test. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp