Re: [LTP] [PATCH] lib: tst_fd: Avoid tst_brk(TCONF, ...) on older distros

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> Actually at least here tst_syscall() needs to be called or it fails on older
> distros due missing ENOSYS check in raw syscall():

Ah, no we have to handle the ENOSYS ourselves as we do in the other
cases. Sorry for not realizing that.

We likely need just:

diff --git a/lib/tst_fd.c b/lib/tst_fd.c
index ab7de81aa..8b26ff8e5 100644
--- a/lib/tst_fd.c
+++ b/lib/tst_fd.c
@@ -141,7 +141,7 @@ static void open_pidfd(struct tst_fd *fd)
 {
        fd->fd = syscall(__NR_pidfd_open, getpid(), 0);
        if (fd->fd < 0)
-               tst_brk(TBROK | TERRNO, "pidfd_open()");
+               tst_res(TCONF | TERRNO, "pidfd_open()");
 }


The tst_sycall() can't be called there at all _because_ it calls
tst_brk() itself.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp