public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] fallocate06: Increase test loop device size to 1GB
Date: Thu, 25 Jan 2024 15:10:44 +0100	[thread overview]
Message-ID: <ZbJr5IB1iCoVls36@yuki> (raw)
In-Reply-To: <20240123160507.31678-1-mdoucha@suse.cz>

Hi!
> diff --git a/testcases/kernel/syscalls/fallocate/fallocate06.c b/testcases/kernel/syscalls/fallocate/fallocate06.c
> index 124fb7eae..83b4d88e6 100644
> --- a/testcases/kernel/syscalls/fallocate/fallocate06.c
> +++ b/testcases/kernel/syscalls/fallocate/fallocate06.c
> @@ -260,6 +260,7 @@ static struct tst_test test = {
>  	.test = run,
>  	.tcnt = ARRAY_SIZE(testcase_list),
>  	.needs_root = 1,
> +	.dev_min_size = 1024,
>  	.mount_device = 1,
>  	.mntpoint = MNTPOINT,
>  	.all_filesystems = 1,

Don't we need to add at least .max_runtime = 120 here as well?

Looks like I'm getting quite close to the default 30s timeout on a
machine with a old good rotating harddisc. I did measure between 10 and
20s for the case that we fill the 1GB filesystem.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2024-01-25 14:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23 16:05 [LTP] [PATCH] fallocate06: Increase test loop device size to 1GB Martin Doucha
2024-01-23 17:22 ` Petr Vorel
2024-01-25 14:10 ` Cyril Hrubis [this message]
2024-01-25 14:12   ` Martin Doucha
2024-01-25 14:18     ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZbJr5IB1iCoVls36@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=mdoucha@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox