From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] Add stat04 test
Date: Fri, 23 Feb 2024 12:09:54 +0100 [thread overview]
Message-ID: <Zdh9AmTW2bp0bCph@yuki> (raw)
In-Reply-To: <20240222233614.GA1417479@pevik>
Hi!
> If SAFE_SYMLINK() fails, free() will not happen. I wonder if we should bother
> (we'd have to set it NULL and add a cleanup function).
There is no point in bothering to deallocate memory if the process is
going to call exit() soon anyways.
My main complaint was that we allocated memory in run() function, which
is obviously a problem for large enough -i...
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-02-23 11:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 15:36 [LTP] [PATCH v4] Add stat04 test Andrea Cervesato
2024-02-22 23:36 ` Petr Vorel
2024-02-23 11:09 ` Cyril Hrubis [this message]
2024-02-23 12:29 ` Andrea Cervesato via ltp
2024-02-23 15:47 ` Petr Vorel
2024-02-24 9:32 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zdh9AmTW2bp0bCph@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox