public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/4] lib/tst_tmpdir: Normalize user defined TMPDIR
Date: Fri, 23 Feb 2024 16:41:24 +0100	[thread overview]
Message-ID: <Zdi8pNjgTDZj1twR@yuki> (raw)
In-Reply-To: <20240207160628.125908-2-pvorel@suse.cz>

Hi!
> +	if (fixed) {
> +		tst_resm(TINFO, "WARNING: Remove double or trailing slashes from TMPDIR,"
> +			 " please fix your setup to: TMPDIR='%s'",
> +			 env_tmpdir);
> +	}

Also why do we bother with a warning when we fixed the path. I would
either fix it and go on or fail the test if it's detected.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2024-02-23 15:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07 16:06 [LTP] [PATCH 0/4] Remove double or trailing slashes in TMPDIR in C API Petr Vorel
2024-02-07 16:06 ` [LTP] [PATCH 1/4] lib/tst_tmpdir: Normalize user defined TMPDIR Petr Vorel
2024-02-07 16:17   ` Petr Vorel
2024-02-23 15:39   ` Cyril Hrubis
2024-03-21  7:14     ` Petr Vorel
2024-02-23 15:41   ` Cyril Hrubis [this message]
2024-02-07 16:06 ` [LTP] [PATCH 2/4] lib: Add test for tst_tmpdir Petr Vorel
2024-02-07 16:18   ` Petr Vorel
2024-02-07 16:06 ` [LTP] [PATCH 3/4] tst_test.sh: Print warning if slashes in $TMPDIR Petr Vorel
2024-02-07 16:06 ` [LTP] [PATCH 4/4] lib: Improve doc related to $TMPDIR default value Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zdi8pNjgTDZj1twR@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox