From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/2] Add shmat04 SysV IPC bug reproducer
Date: Mon, 4 Mar 2024 15:19:32 +0100 [thread overview]
Message-ID: <ZeXYdOwHTND_SVPJ@yuki> (raw)
In-Reply-To: <a1092d18-8f31-49d9-80b8-1436a0c9bd86@suse.com>
Hi!
> > Hmm, it's kind of ugly how we wrap the macro here like that...
> >
> > What about we instead add debugging messages to all the SAFE_MACROS()?
> >
> > Given that we added TDEBUG flag recently we can do soemthing as:
> >
> > tst_res_(TDEBUG, file, lineno, "mprotect(%p, %d, %s)",
> > addr, size, prot_to_str(prot));
> >
> > To the SAFE_MPROTECT() and get the verbose output for free with verbose
> > flag passed to the test.
> >
> > We can do that with all SAFE_MACROS() then we do not have to print most
> > of the messages in this test...
> Is this comment related with the previous patch of the set?
Not at all, I'm just complaining that we are adding debuging print to
the test itself when it would be much cleaner to put it into the test
library instead.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-03-04 14:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 15:37 [LTP] [PATCH v2 0/2] SysV IPC bug reproducer Andrea Cervesato
2024-02-26 15:37 ` [LTP] [PATCH v2 1/2] Add SAFE_MPROTECT() macro Andrea Cervesato
2024-02-26 15:44 ` Cyril Hrubis
2024-03-04 14:35 ` Petr Vorel
2024-03-04 14:47 ` Cyril Hrubis
2024-03-04 16:30 ` Petr Vorel
2024-02-26 15:37 ` [LTP] [PATCH v2 2/2] Add shmat04 SysV IPC bug reproducer Andrea Cervesato
2024-02-26 16:06 ` Cyril Hrubis
2024-03-04 14:17 ` Andrea Cervesato via ltp
2024-03-04 14:19 ` Cyril Hrubis [this message]
2024-03-04 14:32 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeXYdOwHTND_SVPJ@yuki \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox