From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 492A6C48BF6 for ; Mon, 4 Mar 2024 14:20:55 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 647CB3CEB9C for ; Mon, 4 Mar 2024 15:20:53 +0100 (CET) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 0FF3B3CDE37 for ; Mon, 4 Mar 2024 15:20:38 +0100 (CET) Authentication-Results: in-3.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.223.130; helo=smtp-out1.suse.de; envelope-from=chrubis@suse.cz; receiver=lists.linux.it) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 0F3281A01200 for ; Mon, 4 Mar 2024 15:20:36 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A27674E8EB; Mon, 4 Mar 2024 14:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1709562035; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fZRGR1d5H3c5QIB7zhDxMRflqqmndLG9xIX3PotV/Cw=; b=zm2gbDRKTxgcG1Xn2AFlUr5GcQI188O6EHi8CCbi92Na3dOPC8dMnnj5puRdUDv5ey56rj XfeEoMr2ehg1B8dteiltjP1iz0Nfcni1soZroMFIGve2eKGQbqTvHnsqXGqkgFKiJRD3iW NRBItzJC1akIqwc8+wVyr/FkUfj+G2I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1709562035; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fZRGR1d5H3c5QIB7zhDxMRflqqmndLG9xIX3PotV/Cw=; b=lOC6tmNSyy414ZN3eaSio3hsFIw9YQVKbxfFCjPhZLRk6sLOpflCQNx1LyBInpZEs5bdGo AugM0T48t1HltIAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1709562035; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fZRGR1d5H3c5QIB7zhDxMRflqqmndLG9xIX3PotV/Cw=; b=zm2gbDRKTxgcG1Xn2AFlUr5GcQI188O6EHi8CCbi92Na3dOPC8dMnnj5puRdUDv5ey56rj XfeEoMr2ehg1B8dteiltjP1iz0Nfcni1soZroMFIGve2eKGQbqTvHnsqXGqkgFKiJRD3iW NRBItzJC1akIqwc8+wVyr/FkUfj+G2I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1709562035; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fZRGR1d5H3c5QIB7zhDxMRflqqmndLG9xIX3PotV/Cw=; b=lOC6tmNSyy414ZN3eaSio3hsFIw9YQVKbxfFCjPhZLRk6sLOpflCQNx1LyBInpZEs5bdGo AugM0T48t1HltIAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9228713A58; Mon, 4 Mar 2024 14:20:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id szSbIrPY5WUWVgAAD6G6ig (envelope-from ); Mon, 04 Mar 2024 14:20:35 +0000 Date: Mon, 4 Mar 2024 15:19:32 +0100 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20240226153754.24998-1-andrea.cervesato@suse.de> <20240226153754.24998-3-andrea.cervesato@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-4.86 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.06)[61.46%] X-Virus-Scanned: clamav-milter 1.0.3 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 2/2] Add shmat04 SysV IPC bug reproducer X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > Hmm, it's kind of ugly how we wrap the macro here like that... > > > > What about we instead add debugging messages to all the SAFE_MACROS()? > > > > Given that we added TDEBUG flag recently we can do soemthing as: > > > > tst_res_(TDEBUG, file, lineno, "mprotect(%p, %d, %s)", > > addr, size, prot_to_str(prot)); > > > > To the SAFE_MPROTECT() and get the verbose output for free with verbose > > flag passed to the test. > > > > We can do that with all SAFE_MACROS() then we do not have to print most > > of the messages in this test... > Is this comment related with the previous patch of the set? Not at all, I'm just complaining that we are adding debuging print to the test itself when it would be much cleaner to put it into the test library instead. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp