From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23A2AC54E41 for ; Wed, 6 Mar 2024 15:28:07 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 235463CFE3B for ; Wed, 6 Mar 2024 16:28:06 +0100 (CET) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [IPv6:2001:4b78:1:20::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 9A3883C2A69 for ; Wed, 6 Mar 2024 16:27:49 +0100 (CET) Authentication-Results: in-2.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.223.131; helo=smtp-out2.suse.de; envelope-from=chrubis@suse.cz; receiver=lists.linux.it) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id A7F31600B80 for ; Wed, 6 Mar 2024 16:27:48 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 98C852055C; Wed, 6 Mar 2024 15:27:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1709738867; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0V8dp2lfuHN9zGbSzLY07kOL+9dGEW7/ZcBELXDjdeg=; b=cc1Y71r7rDikV5pQvfJJt8rsqvEuIrEdqEzzyvELQovUE4LO+nxsclF8QTh8LGSlmU6qcu f87kTGEIkH/9fUVr5ehQ3CFLMMrx/oTkGP/B1aZx1AgPPsNkb8Wl12B4dIORX0oMZAxA7Y b4w9F48TutV1hHORnXFmGNgv0TOs5m8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1709738867; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0V8dp2lfuHN9zGbSzLY07kOL+9dGEW7/ZcBELXDjdeg=; b=BdZcDctYbFiGEpylknLenX6cz72Rpk6rWJ+muQq9PGm0ALAitDVekwZ2/cgz/TyCP4HYIY E6bqDOjEHA8tgNBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1709738866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0V8dp2lfuHN9zGbSzLY07kOL+9dGEW7/ZcBELXDjdeg=; b=kjwlxczhO8pYBkgCSYbVrormpfa5mdgcWhj8Htb4etAf15EXVugxP8HmumhQOH75io7YMX MIbjNPBbDrk2uwOE8lCyOGW/XM+sMnw9P+wSPkF9nrYQES25RaCO86uJnlpDTFY5ECih6W iyDZN1vsLY8YALtkGqiD/nhWwGap+3I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1709738866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0V8dp2lfuHN9zGbSzLY07kOL+9dGEW7/ZcBELXDjdeg=; b=D1s97Aqde6j/Z4KuhwcMKxIERRwg10jRYYg8ir47LjYdeEgIDynKVSo0N4pWwNtHhCkzPc dN6Do4dJNTJom1Cg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 86B3313A65; Wed, 6 Mar 2024 15:27:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aIO8H3KL6GUoVgAAD6G6ig (envelope-from ); Wed, 06 Mar 2024 15:27:46 +0000 Date: Wed, 6 Mar 2024 16:26:40 +0100 From: Cyril Hrubis To: Dennis Brendel Message-ID: References: <20240306085254.534940-1-dbrendel@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240306085254.534940-1-dbrendel@redhat.com> Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kjwlxczh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=D1s97Aqd X-Spamd-Result: default: False [0.17 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.cz:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:dkim,suse.cz:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.02)[52.49%] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 98C852055C X-Spamd-Bar: / X-Virus-Scanned: clamav-milter 1.0.3 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v3] munlockall: add test case that verifies memory has been unlocked X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > +/*\ > + * [Description] > + * > + * Verify that munlockall(2) unlocks all previously locked memory > + */ > > -char *TCID = "munlockall01"; > -int TST_TOTAL = 1; > +#include > > -#if !defined(UCLINUX) > +#include "tst_test.h" > > -int main(int ac, char **av) > +static void verify_munlockall(void) > { > - int lc; > - > - tst_parse_opts(ac, av, NULL, NULL); > + unsigned long size = 0; > > - setup(); > + SAFE_FILE_LINES_SCANF("/proc/self/status", "VmLck: %ld", &size); > > - /* check looping state */ > - for (lc = 0; TEST_LOOPING(lc); lc++) { > + if (size != 0UL) > + tst_brk(TBROK, "Locked memory after init should be 0 but is %ld", size); > > - tst_count = 0; > + if (mlockall(MCL_CURRENT | MCL_FUTURE) != 0) > + tst_brk(TBROK | TERRNO, "Could not lock memory using mlockall()"); > > - TEST(munlockall()); > + SAFE_FILE_LINES_SCANF("/proc/self/status", "VmLck: %ld", &size); > > - /* check return code */ > - if (TEST_RETURN == -1) { > - tst_resm(TFAIL | TTERRNO, "munlockall() Failed with" > - " return=%ld", TEST_RETURN); > - } else { > - tst_resm(TPASS, "munlockall() passed with" > - " return=%ld ", TEST_RETURN); > + if (size == 0UL) > + tst_brk(TBROK, "Locked memory after mlockall() should be greater than 0, " > + "but is %ld", size); This line can be shorter: tst_brk(TBROK, "After mlockall() locked memory should be >0"); We already checked that size is 0 so no need to print it. > - } > - } > + if (munlockall() != 0) > + tst_brk(TBROK | TERRNO, "Could not unlock memory using munlockall()"); We are testing the munlockall() syscall here so it would be better to use the TST_EXP_PASS() macro. > - /* cleanup and exit */ > - cleanup(); > - tst_exit(); > + SAFE_FILE_LINES_SCANF("/proc/self/status", "VmLck: %ld", &size); > > + if (size != 0UL) > + tst_res(TFAIL, "Locked memory after munlockall() should be 0 but is %ld", size); > + > + else > + tst_res(TPASS, "Memory successfully locked and unlocked"); > } > > -#else > - > -int main(void) > -{ > - tst_resm(TINFO, "test is not available on uClinux"); > - tst_exit(); > -} > - > -#endif /* if !defined(UCLINUX) */ > - > -/* setup() - performs all ONE TIME setup for this test. */ > -void setup(void) > -{ > - tst_require_root(); > - > - tst_sig(NOFORK, DEF_HANDLER, cleanup); > - > - TEST_PAUSE; > -} > - > -/* > - * cleanup() - performs all ONE TIME cleanup for this test at > - * completion or premature exit. > - */ > -void cleanup(void) > -{ > -} > +static struct tst_test test = { > + .test_all = verify_munlockall, > +}; > -- > 2.44.0 > > > -- > Mailing list info: https://lists.linux.it/listinfo/ltp -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp