From: Cyril Hrubis <chrubis@suse.cz>
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] memcontrol03: Using clean page cache to avoid dependency on IO rate
Date: Thu, 14 Mar 2024 12:24:32 +0100 [thread overview]
Message-ID: <ZfLecCIWbfNQ4WTa@yuki> (raw)
In-Reply-To: <20240308023312.25449-1-wegao@suse.com>
Hi!
> Bad IO situation(storage bandwidth ~10MB/sec) will lead background
> writeback has uncertain progress for dirty page. So system can not
> reclaim enough memory for new process and finally lead a unexpected
> OOM.
>
> memcontrol03.c:218: TPASS: Expect: (A/B/E memory.current=0) ~= 0
> memcontrol03.c:116: TPASS: Child 1918 killed by OOM
> memcontrol03.c:224: TPASS: Expect: (A/B memory.current=52588544) ~= 52428800
> memcontrol03.c:129: TFAIL: Expected child 1944 to exit(0), but instead killed by SIGKILL
This is strange the order of messages here does not make any sense. the
last line in the log shouldn't be there at all, the test should have
ended with the "Expect: (A/B memory.current=52588544) ~= 52428800"
Can you please send the whole log?
> Signed-off-by: Wei Gao <wegao@suse.com>
> ---
> testcases/kernel/controllers/memcg/memcontrol03.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/testcases/kernel/controllers/memcg/memcontrol03.c b/testcases/kernel/controllers/memcg/memcontrol03.c
> index 9c6c808e0..9903ba82b 100644
> --- a/testcases/kernel/controllers/memcg/memcontrol03.c
> +++ b/testcases/kernel/controllers/memcg/memcontrol03.c
> @@ -201,6 +201,7 @@ static void test_memcg_min(void)
> sleep(1);
> }
>
> + sync();
> alloc_anon_in_child(trunk_cg[G], MB(148), 0);
>
> SAFE_CG_SCANF(trunk_cg[B], "memory.current", "%ld", c);
> @@ -217,6 +218,7 @@ static void test_memcg_min(void)
> TST_EXP_EXPR(values_close(c[2], 0, 1),
> "(A/B/E memory.current=%ld) ~= 0", c[2]);
>
> + sync();
> alloc_anon_in_child(trunk_cg[G], MB(170), 1);
>
> SAFE_CG_SCANF(trunk_cg[B], "memory.current", "%ld", c);
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-03-14 11:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 2:33 [LTP] [PATCH v1] memcontrol03: Using clean page cache to avoid dependency on IO rate Wei Gao via ltp
2024-03-14 11:24 ` Cyril Hrubis [this message]
2024-03-14 15:46 ` Cyril Hrubis
2024-03-15 3:31 ` [LTP] [PATCH v2] " Wei Gao via ltp
2024-03-15 9:17 ` Petr Vorel
2024-03-15 9:28 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfLecCIWbfNQ4WTa@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox