From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23C5EC54E58 for ; Mon, 25 Mar 2024 12:54:36 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 800613CFED6 for ; Mon, 25 Mar 2024 13:54:34 +0100 (CET) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 8C17F3C1BC5 for ; Mon, 25 Mar 2024 13:54:17 +0100 (CET) Authentication-Results: in-3.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.223.131; helo=smtp-out2.suse.de; envelope-from=chrubis@suse.cz; receiver=lists.linux.it) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 1510D1A0035E for ; Mon, 25 Mar 2024 13:54:16 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 056C45C6C3; Mon, 25 Mar 2024 12:54:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711371256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ftQdwGmVddaNQ80q7vtXTEXs+Q+T53r9XsdCjd5w0+c=; b=RI8VI6c3ngaEVWBXki3thMhInxVKR7EjO+0AiN5yAmKS7q6GcHLn88qTbJOYpWAeVpJsl/ 6RHfpGBfpOfHi2bj1/KG4KmqKhJsQmInXJ1DBmb4lQT7JtHAAiccrrYwiXi2x9s+fWDIom nElf5yx1iK/M06RX06AFZS6IIvRf2Yo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711371256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ftQdwGmVddaNQ80q7vtXTEXs+Q+T53r9XsdCjd5w0+c=; b=8gKJ4uBHbRNITJWIEUy5ZwcnZMzf5xCYHPvuypHuvHce30FFncUixFKokBQ7L+YZ2Vi8Er UGRK9x9GwPJjJvDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711371256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ftQdwGmVddaNQ80q7vtXTEXs+Q+T53r9XsdCjd5w0+c=; b=RI8VI6c3ngaEVWBXki3thMhInxVKR7EjO+0AiN5yAmKS7q6GcHLn88qTbJOYpWAeVpJsl/ 6RHfpGBfpOfHi2bj1/KG4KmqKhJsQmInXJ1DBmb4lQT7JtHAAiccrrYwiXi2x9s+fWDIom nElf5yx1iK/M06RX06AFZS6IIvRf2Yo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711371256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ftQdwGmVddaNQ80q7vtXTEXs+Q+T53r9XsdCjd5w0+c=; b=8gKJ4uBHbRNITJWIEUy5ZwcnZMzf5xCYHPvuypHuvHce30FFncUixFKokBQ7L+YZ2Vi8Er UGRK9x9GwPJjJvDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E755613503; Mon, 25 Mar 2024 12:54:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Q7I1OPdzAWYJYQAAD6G6ig (envelope-from ); Mon, 25 Mar 2024 12:54:15 +0000 Date: Mon, 25 Mar 2024 13:53:20 +0100 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20240322120700.3072-1-metan@ucw.cz> <20240322120700.3072-2-metan@ucw.cz> <20240325123419.GC627989@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240325123419.GC627989@pevik> X-Spamd-Result: default: False [-3.80 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.998]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-3.00)[100.00%] Authentication-Results: smtp-out2.suse.de; none X-Virus-Scanned: clamav-milter 1.0.3 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 1/1] include: doc: Convert comments into linuxdoc X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > generally LGTM, not looking deeply as you plan to send v2. > > Do you plan later to work also on include/tst_test_macros.h? Maybe later, I'm not sure if I get to that part soo enough. > Do you need any help on docs? Proof reading is always welcomed, but please wait for v2. > Also I should find time to study how to generate docs locally. That is actually quite easy, you need the patchset from andrea with this patch on the top. Then you need install sphinx and the linuxdoc tooling. The spinx is usually packaged in your distro, the linuxdoc has to be installed with pip as described at: https://github.com/return42/linuxdoc After that it's just a matter of typing make in the doc_new directory. > ... > > /** > > - * Add, check or remove a capabilities > > + * tst_cap_setup() - Add, check or remove a capabilities. > > + * > > + * @cap: An {} terminated array of capabilities to alter. > > + * @action_mask: Decides which actions are done, i.e. only drop caps, add them > > + * or both. > > * > > * Takes a NULL terminated array of structs which describe whether some > > * capabilities are needed or not and mask that determines subset of the > > * actions to be performed. Loops over the array and if mask matches the > > * element action it's passed to tst_cap_action(). > > */ > > -void tst_cap_setup(struct tst_cap *cap, unsigned int action_mask); > > +void tst_cap_setup(struct tst_cap *cap, enum tst_cap_act action_mask); > > This is a real code change, which could be merged separately on the docs change. > But I see whole patchset is not only about docs, but about moving definitions > into enums thus OK for me. Some of headers need a bit of cleaning so that the documentation looks nicer. It could be done in a separate patch if you really want to, but I do not think that it's that important. > > #endif /* TST_CAPABILITY_H */ > > diff --git a/include/tst_checkpoint.h b/include/tst_checkpoint.h > > index 1b6911d73..62d87d60b 100644 > > --- a/include/tst_checkpoint.h > > +++ b/include/tst_checkpoint.h > > @@ -1,24 +1,86 @@ > > -/* SPDX-License-Identifier: GPL-2.0-or-later > > +// SPDX-License-Identifier: GPL-2.0-or-later > > I guess this change will cause checkpatch.pl to complain: > > tst_checkpoint.h:1: WARNING: Improper SPDX comment style for 'tst_checkpoint.h', please use '/*' instead > tst_checkpoint.h:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 Sigh, I was sure that I fixed that, will fix in v2. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp