Re: [LTP] [PATCH] input_helper: Modify the check range of the input event number

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> If the input event number is greater than 32, the newly added event ID
> will be 256 or later.

I've tried it and it seems to work that way, but it strange why these
are numbered discontinously. May be even a bug.

> When there were already 32 input events in the device, this test program
> only checked 0~99, so it failed because it could not find a new input
> event ID.
> In order to eliminate this failure, we changed the event ID range to be
> checked by this test program to 0~356 (256+100).

I guess that since we are changing the code we can as well add a bigger
value there. Let's bump it at least ten times so that we don't have to
change it again later on.

> Bug: 330269984
> Test: ltp
> Change-Id: I1b53008b15641fcdccf214af9183de1c29a3309c
> ---
> 
> diff --git a/testcases/kernel/input/input_helper.c b/testcases/kernel/input/input_helper.c
> index c929de6..f086ae5 100644
> --- a/testcases/kernel/input/input_helper.c
> +++ b/testcases/kernel/input/input_helper.c
> @@ -41,7 +41,7 @@
>       int ret, fd = -1;
>       unsigned int i;
> 
> -     for (i = 0; i < 100; i++) {
> +     for (i = 0; i < 356; i++) {
>             snprintf(path, sizeof(path), "/dev/input/event%i", i);
> 
>             fd = open(path, O_RDONLY);
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp