[LTP] [COMMITTED][PATCH 1/1] doc: Remove make install

[LTP] [COMMITTED][PATCH 1/1] doc: Remove make install

[Petr Vorel]

make install in doc is broken on out-of-tree builds. Although we may
want to install generated docs (final html), for now just disable the
target to fix CI. Previously was the install target used just for
installing man pages (which are deprecated anyway).

Fixes: 4a72aada8 ("New LTP documentation")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Makefile b/Makefile
index 49d91f4d5..96edd5a80 100644
--- a/Makefile
+++ b/Makefile
@@ -38,7 +38,6 @@ export UCLINUX
 # We're not using uclinux based targets (default).
 ifneq ($(UCLINUX),1)
 COMMON_TARGETS		:= pan utils
-INSTALL_TARGETS		:= doc
 endif
 
 define target_to_dir_dep_mapping
-- 
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [COMMITTED][PATCH 1/1] doc: Remove make install

[Cyril Hrubis]

Hi!
> make install in doc is broken on out-of-tree builds. Although we may
> want to install generated docs (final html), for now just disable the
> target to fix CI. Previously was the install target used just for
> installing man pages (which are deprecated anyway).
> 
> Fixes: 4a72aada8 ("New LTP documentation")
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  Makefile | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 49d91f4d5..96edd5a80 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -38,7 +38,6 @@ export UCLINUX
>  # We're not using uclinux based targets (default).
>  ifneq ($(UCLINUX),1)

We should probably remove the UCLINUX later on as well...

>  COMMON_TARGETS		:= pan utils
> -INSTALL_TARGETS		:= doc
>  endif
>  
>  define target_to_dir_dep_mapping
> -- 
> 2.43.0
> 

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [COMMITTED][PATCH 1/1] doc: Remove make install

[Petr Vorel]

> Hi!
> > make install in doc is broken on out-of-tree builds. Although we may
> > want to install generated docs (final html), for now just disable the
> > target to fix CI. Previously was the install target used just for
> > installing man pages (which are deprecated anyway).

> > Fixes: 4a72aada8 ("New LTP documentation")
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> >  Makefile | 1 -
> >  1 file changed, 1 deletion(-)

> > diff --git a/Makefile b/Makefile
> > index 49d91f4d5..96edd5a80 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -38,7 +38,6 @@ export UCLINUX
> >  # We're not using uclinux based targets (default).
> >  ifneq ($(UCLINUX),1)

> We should probably remove the UCLINUX later on as well...

Agree. Do you mean whole UCLINUX (I could rebase the patch I have sent)
or just in here in this Makefile (or in all Makefiles?)

Kind regards,
Petr

> >  COMMON_TARGETS		:= pan utils
> > -INSTALL_TARGETS		:= doc
> >  endif

> >  define target_to_dir_dep_mapping
> > -- 
> > 2.43.0

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [COMMITTED][PATCH 1/1] doc: Remove make install

[Cyril Hrubis]

Hi!
> Agree. Do you mean whole UCLINUX (I could rebase the patch I have sent)
> or just in here in this Makefile (or in all Makefiles?)

Ideally remove all UCLINUX from Makefiles in a separate patch...

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp