From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: calum.mackay@oracle.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] mremap06: fallocate is not supported on nfsv3
Date: Wed, 10 Apr 2024 11:30:23 +0200 [thread overview]
Message-ID: <ZhZcL9cH5bVDWL_k@yuki> (raw)
In-Reply-To: <20240409101753.GA107959@pevik>
Hi!
> > > > - if (ret == -1)
> > > > + if (ret != 0) {
> > > > + if (errno == EOPNOTSUPP || errno == ENOSYS) {
> > > > + tst_brk(TCONF,
> > > > + "fallocate system call is not implemented");
> > > > + }
> > > > tst_brk(TBROK, "fallocate() failed");
> > > > + return;
>
> I suggest to merge this now, without return (it can be removed before merge).
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
Shouldn't we limit this only to nfs, to make sure that fallocate() is
not accidentally disabled on other filesystems? At least that what I
suggested when I replied to the patch.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-04-10 9:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 15:00 [LTP] [PATCH] mremap06: fallocate is not supported on nfsv3 Samasth Norway Ananda
2024-04-05 12:01 ` Cyril Hrubis
2024-04-08 21:50 ` Samasth via ltp
2024-04-09 10:17 ` Petr Vorel
2024-04-10 9:30 ` Cyril Hrubis [this message]
2024-04-10 9:46 ` Petr Vorel
2024-04-10 9:53 ` Petr Vorel
2024-04-10 10:08 ` Cyril Hrubis
2024-04-10 13:33 ` Petr Vorel
2024-04-11 5:58 ` Samasth via ltp
-- strict thread matches above, loose matches on Subject: below --
2024-03-26 20:56 Samasth Norway Ananda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhZcL9cH5bVDWL_k@yuki \
--to=chrubis@suse.cz \
--cc=calum.mackay@oracle.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox