Re: [LTP] [PATCH 07/31] tlibio.c: Remove UCLINUX

Andrea Cervesato via ltp
2024-04-12T09:08:39Z

Hi!

On 4/12/24 10:57, Cyril Hrubis wrote:
> Hi!
>>>> IMHO you are wrong here. IMHO uCLinux-ng [1], still used libc (used in Buildroot
>>>> and openembedded). And log in e5e938f4b7 (2009) suggests that it's about libc.
>>>> But the question is whether it's still needed. I could try to remove these and
>>>> test, but as a separate effort.
>>> You are right, these should be converted into configure checks later on.
>>>
>>> And the tlibio should probably be rewritten completely. So let's keep
>>> the patch as it is.
>>>
>> I started to rewrite part of that library when I was working on
>> growfiles test rewrite, but the complexity of it, the amount of nested
>> statements and macro directives made me crazy.
>> Waiting for a better moment to restart rewriting it, but work is on-going.
> Maybe it would be better to do this in a steps, first remove everything
> that is inside the ifdefs for hpux, sgi etc. and only then start working
> with the actual code...
>
Well that's the easiest part. growfiles has a really huge amount of bad
code, it's the biggest in the whole LTP suite and (unfortunately) it's a
really important one.
It will take a bit...probably it will be incremental.

Andrea