Re: [LTP] [PATCH] Add case about arch_prctl syscall.

Cyril Hrubis
2024-05-07T12:51:34Z

Hi!
> +static void run(unsigned int index)
> +{
> + struct tcase tc = tcases[index];
> +
> + TEST(arch_prctl_set(ARCH_SET_CPUID, tc.input));
> +
> + if (TST_RET == tc.set_exp)
> + if (tc.set_exp == -1)
> + tst_res((TST_ERR == tc.tst_errno ? TPASS : TFAIL),
> + "set cpuid, expect: %s, get: %s",
> + tst_strerrno(tc.tst_errno),
> + tst_strerrno(TST_ERR));
> + else
> + tst_res(TPASS, "set cpuid succeed.");
> + else
> + tst_res(TFAIL, "set cpuid failed.");

This is kind of ugly, why can't we just do:

if (tag)
TST_EXP_PASS(arch_prctl_set(ARCH_SET_CPUID, index));
else
TST_EXP_FAIL(arch_prctl_set(ARCH_SET_CPUID, index), ENODEV);

> + TEST(arch_prctl_get(ARCH_GET_CPUID));
> +
> + if (TST_RET == tc.get_exp)
> + tst_res(TPASS, "get cpuid succeed.");
> + else
> + tst_res(TFAIL, "get cpuid failed.");

We have to check the errno here as well, just branch on the tag as well:

if (tag) {
TEST(arch_prctl_get(ARCH_GET_CPUID));

if (TST_RET == index)
tst_res(TPASS, "...");
else
tst_res(FAIL, "...");
} else {
TST_EXP_FAIL(arch_prctl_get(ARCH_GET_CPUID), ENODEV);
}

Generally the use of TST_EXP_FAIL() is prefered whenever possible.

> +}
> +
> +static struct tst_test test = {
> + .test = run,
> + .setup = setup,
> + .tcnt = ARRAY_SIZE(tcases),
> + .min_kver = "4.12",
> + .supported_archs = (const char *const []){"x86_64", "x86", NULL}
> +};
> +
> +#else /* HAVE_ASM_PRCTL_H */
> +TST_TEST_TCONF("missing <asm/prctl.h>");
> +#endif
> --
> 2.39.3
>

--
Cyril Hrubis
chrubis@suse.cz