* [LTP] [PATCH] open_posix_testsuite: Remove inclomplete warning commandline argument @ 2024-05-08 21:01 Detlef Riekenberg via ltp 2024-05-09 9:21 ` Cyril Hrubis 0 siblings, 1 reply; 7+ messages in thread From: Detlef Riekenberg via ltp @ 2024-05-08 21:01 UTC (permalink / raw) To: ltp The Open Posix testsuite calls the compiler with the commandline argument "-W", but that is not a supported gcc warning option and breaks other compiler. This patch removes the broken "-W" commandline argument. Fixes commit 8071ba7 References: https://gcc.gnu.org/onlinedocs/gcc/Option-Summary.html https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html -- Regards ... Detlef Signed-off-by: Detlef Riekenberg <wine.dev@web.de> --- testcases/open_posix_testsuite/include/mk/config.mk.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testcases/open_posix_testsuite/include/mk/config.mk.in b/testcases/open_posix_testsuite/include/mk/config.mk.in index c9a4b5c5a..a43de6641 100644 --- a/testcases/open_posix_testsuite/include/mk/config.mk.in +++ b/testcases/open_posix_testsuite/include/mk/config.mk.in @@ -14,4 +14,4 @@ testdir_rel := @testdir@ testdir := ${prefix}/${testdir_rel} testdir_bin := ${testdir}/bin -CFLAGS += -std=c99 -D_POSIX_C_SOURCE=200809L -D_XOPEN_SOURCE=700 -W -Wall +CFLAGS += -std=c99 -D_POSIX_C_SOURCE=200809L -D_XOPEN_SOURCE=700 -Wall -- 2.40.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH] open_posix_testsuite: Remove inclomplete warning commandline argument 2024-05-08 21:01 [LTP] [PATCH] open_posix_testsuite: Remove inclomplete warning commandline argument Detlef Riekenberg via ltp @ 2024-05-09 9:21 ` Cyril Hrubis 2024-05-13 4:34 ` Joerg Vehlow 0 siblings, 1 reply; 7+ messages in thread From: Cyril Hrubis @ 2024-05-09 9:21 UTC (permalink / raw) To: Detlef Riekenberg; +Cc: ltp Hi! > The Open Posix testsuite calls the compiler with the commandline argument > "-W", but that is not a supported gcc warning option > and breaks other compiler. > > This patch removes the broken "-W" commandline argument. Isn't -W old name for -Wextra? -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH] open_posix_testsuite: Remove inclomplete warning commandline argument 2024-05-09 9:21 ` Cyril Hrubis @ 2024-05-13 4:34 ` Joerg Vehlow 2024-05-13 10:47 ` Petr Vorel 0 siblings, 1 reply; 7+ messages in thread From: Joerg Vehlow @ 2024-05-13 4:34 UTC (permalink / raw) To: Cyril Hrubis, Detlef Riekenberg; +Cc: ltp Hi, Am 5/9/2024 um 11:21 AM schrieb Cyril Hrubis: > Hi! >> The Open Posix testsuite calls the compiler with the commandline argument >> "-W", but that is not a supported gcc warning option >> and breaks other compiler. >> >> This patch removes the broken "-W" commandline argument. > > Isn't -W old name for -Wextra? exactly that is what gcc and clang documentation states. On top of that Additionally it is nothing introduced by 8071ba7, but already by ff4e69314c1 back in 2013 by no one else but you Cyril ;) I guess changing it to -Wextra wouldn't hurt and is what gcc recommends. Jörg -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH] open_posix_testsuite: Remove inclomplete warning commandline argument 2024-05-13 4:34 ` Joerg Vehlow @ 2024-05-13 10:47 ` Petr Vorel 2024-05-13 12:26 ` Cyril Hrubis 0 siblings, 1 reply; 7+ messages in thread From: Petr Vorel @ 2024-05-13 10:47 UTC (permalink / raw) To: Joerg.Vehlow; +Cc: Detlef Riekenberg, ltp Hi all, > Hi, > Am 5/9/2024 um 11:21 AM schrieb Cyril Hrubis: > > Hi! > >> The Open Posix testsuite calls the compiler with the commandline argument > >> "-W", but that is not a supported gcc warning option > >> and breaks other compiler. > >> This patch removes the broken "-W" commandline argument. > > Isn't -W old name for -Wextra? > exactly that is what gcc and clang documentation states. > On top of that > Additionally it is nothing introduced by 8071ba7, but already by > ff4e69314c1 back in 2013 by no one else but you Cyril ;) Yes, it should be: Fixes: ff4e69314 ("open_posix_testsuite: Enable warnings.") > I guess changing it to -Wextra wouldn't hurt and is what gcc recommends. +1 for replacing -W with -Wextra FYI if we are interested what is behind -Wextra https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-W https://github.com/llvm-mirror/clang/blob/master/include/clang/Basic/DiagnosticGroups.td Kind regards, Petr > Jörg -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH] open_posix_testsuite: Remove inclomplete warning commandline argument 2024-05-13 10:47 ` Petr Vorel @ 2024-05-13 12:26 ` Cyril Hrubis 2024-05-13 13:09 ` Petr Vorel 0 siblings, 1 reply; 7+ messages in thread From: Cyril Hrubis @ 2024-05-13 12:26 UTC (permalink / raw) To: Petr Vorel; +Cc: Detlef Riekenberg, ltp, Joerg.Vehlow Hi! > +1 for replacing -W with -Wextra Let's go with that -Wextra has been out there for long enough. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH] open_posix_testsuite: Remove inclomplete warning commandline argument 2024-05-13 12:26 ` Cyril Hrubis @ 2024-05-13 13:09 ` Petr Vorel 0 siblings, 0 replies; 7+ messages in thread From: Petr Vorel @ 2024-05-13 13:09 UTC (permalink / raw) To: Cyril Hrubis; +Cc: Detlef Riekenberg, ltp, Joerg.Vehlow Hi Detlef, > Hi! > > +1 for replacing -W with -Wextra > Let's go with that -Wextra has been out there for long enough. Will you please send v2 and --cc us? Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 7+ messages in thread
* [LTP] [PATCH] open_posix_testsuite: Remove inclomplete warning commandline argument @ 2024-05-08 20:51 Detlef Riekenberg via ltp 0 siblings, 0 replies; 7+ messages in thread From: Detlef Riekenberg via ltp @ 2024-05-08 20:51 UTC (permalink / raw) To: ltp The Open Posix testsuite calls the compiler with the commandline argument "-W", but that is not a supported gcc warning option and breaks other compiler. This patch removes the broken "-W" commandline argument. Fixes commit 8071ba7 References: https://gcc.gnu.org/onlinedocs/gcc/Option-Summary.html https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html -- Regards ... Detlef Signed-off-by: Detlef Riekenberg <wine.dev@web.de> --- testcases/open_posix_testsuite/include/mk/config.mk.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-05-13 13:10 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-05-08 21:01 [LTP] [PATCH] open_posix_testsuite: Remove inclomplete warning commandline argument Detlef Riekenberg via ltp 2024-05-09 9:21 ` Cyril Hrubis 2024-05-13 4:34 ` Joerg Vehlow 2024-05-13 10:47 ` Petr Vorel 2024-05-13 12:26 ` Cyril Hrubis 2024-05-13 13:09 ` Petr Vorel -- strict thread matches above, loose matches on Subject: below -- 2024-05-08 20:51 Detlef Riekenberg via ltp
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox