Re: [LTP] [PATCH v6] Refactor fork14 using new LTP API

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> +#ifndef TST_ABI32
> +
>  #define LARGE		(16 * 1024)
>  #define EXTENT		(16 * 1024 + 10)
>  
> @@ -48,7 +52,7 @@ static void run(void)
>  			if (failures > 10) {
>  				tst_brk(TCONF, "mmap() fails too many "
>  					"times, so it's almost impossible to "
> -					"get a vm_area_struct sized 16TB.");
> +					"get a vm_area_struct sized 16TB");
>  			}
>  
>  			continue;
> @@ -115,9 +119,11 @@ static struct tst_test test = {
>  	.setup = setup,
>  	.cleanup = cleanup,
>  	.forks_child = 1,
> -	.skip_in_compat = 1,
>  	.tags = (const struct tst_tag[]) {
>  		{"linux-git", "7edc8b0ac16c"},
>  		{}
>  	}
>  };
> +#else
> +TST_TEST_TCONF("Not supported on x86 in 32-bit");
> +#endif

I think that adding ifdefs and removing metadata is actually a step
back. I suppose that we need .skip_on_32bit or something similar.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp