public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/3] lib: Add .skip_in_32bit
Date: Mon, 20 May 2024 17:38:17 +0200	[thread overview]
Message-ID: <Zktuab9EaIpC1qDe@yuki> (raw)
In-Reply-To: <20240516005558.253199-3-pvorel@suse.cz>

Hi!
> @@ -494,6 +497,7 @@ struct tst_ulimit_val {
>  	unsigned int skip_in_lockdown:1;
>  	unsigned int skip_in_secureboot:1;
>  	unsigned int skip_in_compat:1;
> +	unsigned int skip_in_32bit:1;

I was thinking about this and maybe it would make more sense to make
this more generic. If we ever need to add flags for a test to be skipped
on 64bit ABI we would have to add another flag. One example would be an
EOVERFLOW error from mmap() that can happen only on 32bit.

So maybe it would make sense to change this to be .needs_abi_bits and
the possible values would be 32 and 64.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-05-20 15:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16  0:55 [LTP] [PATCH 0/3] .skip_in_32bit + rewrite fork14 to new API Petr Vorel
2024-05-16  0:55 ` [LTP] [PATCH 1/3] tst_kernel.h: Convert docs to sphinx Petr Vorel
2024-05-16  0:55 ` [LTP] [PATCH 2/3] lib: Add .skip_in_32bit Petr Vorel
2024-05-20 15:38   ` Cyril Hrubis [this message]
2024-05-21  7:51     ` Petr Vorel
2024-05-16  0:55 ` [LTP] [PATCH v7 3/3] Refactor fork14 using new LTP API Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zktuab9EaIpC1qDe@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox