From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84C93C25B74 for ; Tue, 21 May 2024 15:13:37 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id DF7A53D009F for ; Tue, 21 May 2024 17:13:35 +0200 (CEST) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [IPv6:2001:4b78:1:20::5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 09E5D3CF327 for ; Tue, 21 May 2024 17:13:20 +0200 (CEST) Authentication-Results: in-5.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=2a07:de40:b251:101:10:150:64:1; helo=smtp-out1.suse.de; envelope-from=chrubis@suse.cz; receiver=lists.linux.it) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 355D1600D24 for ; Tue, 21 May 2024 17:13:19 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AAF5022049; Tue, 21 May 2024 15:13:18 +0000 (UTC) Authentication-Results: smtp-out1.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9B9D013685; Tue, 21 May 2024 15:13:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id EjvOJA66TGZlaQAAD6G6ig (envelope-from ); Tue, 21 May 2024 15:13:18 +0000 Date: Tue, 21 May 2024 17:12:30 +0200 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20240521105348.126316-1-pvorel@suse.cz> <20240521105348.126316-6-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240521105348.126316-6-pvorel@suse.cz> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Queue-Id: AAF5022049 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Virus-Scanned: clamav-milter 1.0.3 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 5/5] setsockopt0[38]: Use tst_is_compat_mode() X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > testcases/kernel/syscalls/setsockopt/setsockopt03.c | 5 ++--- > testcases/kernel/syscalls/setsockopt/setsockopt08.c | 6 ++---- > 2 files changed, 4 insertions(+), 7 deletions(-) > > diff --git a/testcases/kernel/syscalls/setsockopt/setsockopt03.c b/testcases/kernel/syscalls/setsockopt/setsockopt03.c > index 7a1458277..d910280c8 100644 > --- a/testcases/kernel/syscalls/setsockopt/setsockopt03.c > +++ b/testcases/kernel/syscalls/setsockopt/setsockopt03.c > @@ -48,9 +48,8 @@ struct payload { > > static void setup(void) > { > - if (tst_kernel_bits() == 32 || sizeof(long) > 4) > - tst_res(TCONF, > - "The vulnerability was only present in 32-bit compat mode"); > + if (!tst_is_compat_mode()) > + tst_res(TCONF, "The vulnerability was only present in 32-bit compat mode"); > } > > static void run(void) > diff --git a/testcases/kernel/syscalls/setsockopt/setsockopt08.c b/testcases/kernel/syscalls/setsockopt/setsockopt08.c > index 7f8243de1..3b7bd8482 100644 > --- a/testcases/kernel/syscalls/setsockopt/setsockopt08.c > +++ b/testcases/kernel/syscalls/setsockopt/setsockopt08.c > @@ -95,10 +95,8 @@ static void *buffer; > > void setup(void) > { > - if (tst_kernel_bits() == 32 || sizeof(long) > 4) { > - tst_res(TINFO, > - "The vulnerability was only present in 32-bit compat mode"); > - } > + if (!tst_is_compat_mode()) > + tst_res(TINFO, "The vulnerability was only present in 32-bit compat mode"); > > tst_setup_netns(); > } I guess this is something that should be looked into after the release, either we will need .needs_compat flag or relax the condtions... -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp