[LTP] [PATCH 1/1] sparse-ltp: Fix bogus warning

[LTP] [PATCH 1/1] sparse-ltp: Fix bogus warning

[Petr Vorel]

tst_tmpdir.c:347:6: warning: Symbol 'tst_purge_dir' has no prototype or
library ('tst_') prefix. Should it be static?

Fixes: abe9b1792 ("tools/sparse: Add static check")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 tools/sparse/sparse-ltp.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tools/sparse/sparse-ltp.c b/tools/sparse/sparse-ltp.c
index d649ee7b7..fff4bd4e6 100644
--- a/tools/sparse/sparse-ltp.c
+++ b/tools/sparse/sparse-ltp.c
@@ -148,9 +148,11 @@ static void check_symbol_visibility(const struct symbol *const sym)
 	if (sym->ident == &main_ident)
 		return;
 
-	warning(sym->pos,
-		"Symbol '%s' has no prototype or library ('tst_') prefix. Should it be static?",
-		name);
+	if (!has_lib_prefix) {
+		warning(sym->pos,
+			"Symbol '%s' has no prototype or library ('tst_') prefix. Should it be static?",
+			name);
+	}
 }
 
 /* See base_type() in dissect.c */
-- 
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] sparse-ltp: Fix bogus warning

[Cyril Hrubis]

Hi!
> tst_tmpdir.c:347:6: warning: Symbol 'tst_purge_dir' has no prototype or
> library ('tst_') prefix. Should it be static?

Actually this is a correct check. The idea is a bit different, we are
trying to make sure that there is a prototype in the headers for the
function. If that is true, the sym->same_symbol points to that symbol
instance and the check exists before it reaches that warning.

So the actuall problem here is that the prototype is in a strange place,
i.e. tst_device.h which is not included into tst_tmpdir.c.

Obvious fix would be including tst_device.h into tst_tmpdir.c however
I'm not sure that the function to purge the directory belongs to the
tst_device.h to begin with. Maybe we should add just tst_tmpdir.h with
that function and include it into right places, i.e. tst_test.h and
tst_tmpdir.c.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp