From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 0/2] lib: Add TINFO_WARN
Date: Wed, 29 May 2024 17:10:35 +0200 [thread overview]
Message-ID: <ZldFa-3CXXbVKmVW@yuki> (raw)
In-Reply-To: <37603272-8ea2-4828-96df-4b6381cc26ad@suse.com>
Hi!
> I'm not sure about this. Why not enabling TINFO + TWARN combination instead?
>
> tst_res(TINFO | TWARN, "my message");
That's even more confusing. Does that propagate into results or not?
To be honest we even have problem deciding if we should use TINFO or
TWARN in some cases and adding third variant would make things even
worse, sicne we would have three options.
So I would really keep just TINFO which is something that is printed by
default but does not propagate into results and TWARN that is printed as
well but propagates into results.
Maybe it would be even better to actually remove TWARN. That way we
would have only TFAIL and TBROK that propagate into results since TWARN
is kind of lesser TBROK anyways...
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-05-29 15:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 22:29 [LTP] [PATCH 0/2] lib: Add TINFO_WARN Petr Vorel
2024-05-27 22:29 ` [LTP] [PATCH 1/2] " Petr Vorel
2024-05-27 22:29 ` [LTP] [PATCH 2/2] tree: Use TINFO_WARN Petr Vorel
2024-05-28 6:04 ` [LTP] [PATCH 0/2] lib: Add TINFO_WARN Andrea Cervesato via ltp
2024-05-29 15:10 ` Cyril Hrubis [this message]
2024-06-20 5:36 ` Petr Vorel
2024-06-20 8:05 ` Li Wang
2024-06-20 11:25 ` Petr Vorel
2024-06-21 13:22 ` Li Wang
2024-06-21 13:39 ` Petr Vorel
2024-06-21 13:47 ` Li Wang
2024-06-21 13:53 ` Petr Vorel
-- strict thread matches above, loose matches on Subject: below --
2024-05-28 12:05 Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZldFa-3CXXbVKmVW@yuki \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox