public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 3/3] Add ioctl_ficlone03 test
Date: Fri, 31 May 2024 10:03:21 +0200	[thread overview]
Message-ID: <ZlmESfb2JbYbSG1_@rei> (raw)
In-Reply-To: <82ac2455-ab1c-4bdf-b4e3-5ae56dfb9871@suse.com>

Hi!
> > Can we move these invalid_fd tests into a separate test and use tst_fd
> > to loop over all kinds of invalid input and output file descriptors?
> >
> I don't know if it's worth to loop over all possible cases. Each one of 
> them has a specific test case.

This was actually requested by kernel developers, to feed the syscalls
with all kind of unexpected file descriptors.

> Also, invalid_fd test cases would look so simple that it makes more 
> sense to keep it here.

Fair enough, we can keep these two here, but we need a tst_fd test as
well.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-05-31  8:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-30  7:15 [LTP] [PATCH 0/3] Add ioctl_ficlone testing suite Andrea Cervesato
2024-05-30  7:15 ` [LTP] [PATCH 1/3] Add ioctl_ficlone01 test Andrea Cervesato
2024-05-30 10:48   ` Cyril Hrubis
2024-05-31  7:15     ` Andrea Cervesato via ltp
2024-05-31  8:01       ` Cyril Hrubis
2024-05-31  8:27         ` Andrea Cervesato via ltp
2024-05-30  7:15 ` [LTP] [PATCH 2/3] Add ioctl_ficlone02 test Andrea Cervesato
2024-05-30 10:49   ` Cyril Hrubis
2024-05-31 11:00     ` Andrea Cervesato via ltp
2024-05-30  7:15 ` [LTP] [PATCH 3/3] Add ioctl_ficlone03 test Andrea Cervesato
2024-05-30 10:52   ` Cyril Hrubis
2024-05-31  7:53     ` Andrea Cervesato via ltp
2024-05-31  8:03       ` Cyril Hrubis [this message]
2024-07-11 13:41         ` Andrea Cervesato via ltp
2024-07-12  7:36         ` Andrea Cervesato via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZlmESfb2JbYbSG1_@rei \
    --to=chrubis@suse.cz \
    --cc=andrea.cervesato@suse.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox