From: Cyril Hrubis <chrubis@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] lib: tst_test: Add per filesystem mkfs and mount opts
Date: Tue, 11 Jun 2024 14:23:43 +0200 [thread overview]
Message-ID: <ZmhBz97t8v4FuJPF@yuki> (raw)
In-Reply-To: <590abdcd-9253-434b-889b-4e481cbe5e12@suse.cz>
Hi!
> It's a lot less confusing than having half of the filesystem settings in
> .fs and the other half in .fss when you enable .all_filesystems.
There is a subltle difference in the design which I tried to explain in
the documentation comment. If you enable .all_filesystems all parameters
are taken from the fs and the fss severs only as an override for the
defaults in fs. Since the test has no idea about which filesystems
are tested on .all_filesystems the defaults has to be stored somewhere.
Another option would be storing the defaults in .fss with NULL
filesystem name, but that would IMHO be even more confusing.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-06-11 12:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 12:34 [LTP] [PATCH 0/2] tst_test per FS options and small cleanup Cyril Hrubis
2024-06-03 12:34 ` [LTP] [PATCH 1/2] lib: tst_test: Add per filesystem mkfs and mount opts Cyril Hrubis
2024-06-03 13:22 ` Andrea Cervesato via ltp
2024-06-07 10:29 ` Petr Vorel
2024-06-11 9:54 ` Martin Doucha
2024-06-11 11:02 ` Petr Vorel
2024-06-11 11:44 ` Martin Doucha
2024-06-11 12:23 ` Cyril Hrubis [this message]
2024-06-11 12:42 ` Martin Doucha
2024-06-11 13:11 ` Cyril Hrubis
2024-06-11 13:16 ` Martin Doucha
2024-06-11 13:18 ` Cyril Hrubis
2024-06-03 12:34 ` [LTP] [PATCH 2/2] syscalls: quotactl: Move mkfs opts into tst_test Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmhBz97t8v4FuJPF@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox