From: Cyril Hrubis <chrubis@suse.cz>
To: John Stultz <jstultz@google.com>
Cc: kernel-team@android.com,
Darren Hart <darren@os.amperecomputing.com>,
ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] include/tst_timer: Add TST_NO_LIBLTP
Date: Thu, 27 Jun 2024 12:26:29 +0200 [thread overview]
Message-ID: <Zn0-VWfPTqrAzuuj@yuki> (raw)
In-Reply-To: <CANDhNCpKJ5i41eNw_sthFQfdTaYoJU76swEWmwmBy_Y2t2pszQ@mail.gmail.com>
Hi!
> So instead you can implement in a header once:
>
> #ifndef TST_NO_LIBLTP
> static inline void test_brk(int i, char *s, long d)
> {
> abort();
> }
> #endif
>
> And then the downstream users don't need to have #ifdefs littering their logic.
>
> Again, just an idea.
That indeed looks better, will send v2.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-06-27 10:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 13:30 [LTP] [PATCH v1] include/tst_timer: Add TST_NO_LIBLTP Cyril Hrubis
2024-06-26 18:58 ` John Stultz via ltp
2024-06-27 10:26 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zn0-VWfPTqrAzuuj@yuki \
--to=chrubis@suse.cz \
--cc=darren@os.amperecomputing.com \
--cc=jstultz@google.com \
--cc=kernel-team@android.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox