Re: [LTP] [PATCH 2/6] sched_football: Use atomic for ball

Li Wang
2024-06-27T03:32:49Z

Hi John,

On Thu, Jun 27, 2024 at 1:01 AM John Stultz <jstultz@google.com> wrote:

> On Tue, Jun 25, 2024 at 7:26 PM Li Wang <liwang@redhat.com> wrote:
> > John Stultz <jstultz@google.com> wrote:
> >>
> >> Should the old --with-realtime-testsuite option be removed then?
> >
> >
> > No, we need it.
> >
> > When configuring LTP without the --with-realtime-testsuite option, it
> will
> > skip building the stuff under testcases/realtime/ by default.
>
> Right. But as I mentioned earlier, building with it seems to be broken
> currently?
>

Not broken, that's because you didn't build in correct way.
'make autotools' is the first necessary step for the build.

> > Unless you build it manually like: make -C testcase/realtime/.
>
> Should maybe the realtime tests just be included in the normal build
> now? Or is it still useful to keep it separate due to some of the
> additional dependencies it needs?
>

Hmm, at least in the build.sh script, it enables in the configuration phase,
if you build by that (./build.sh) it should be included.

But I'm not very sure if it's worth to enable by default. @Cryil, @Petr.

See: https://github.com/linux-test-project/ltp/blob/master/build.sh#L14

--
Regards,
Li Wang