public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] msgstress01: remove TWARN from runtime remaining
Date: Thu, 27 Jun 2024 14:53:35 +0200	[thread overview]
Message-ID: <Zn1gzzTTnm32jeE6@yuki> (raw)
In-Reply-To: <CAEemH2erMqJD37nZ6AoWp_5pvE3ADd0+muxGd3fM_y7xdNd0XA@mail.gmail.com>

Hi!
>         if (!(*fail))
> -               tst_res(TPASS, "Test passed. All messages have been
> received");
> +               tst_res(TPASS, "Some messages received");

We could have done:

		if (*stop)
			tst_res(TPASS, "Some messages received");
		else
			tst_res(TPASS, "All messages received");

But I guess that in the end nobody will read the logs as long as the
test succeeds...

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2024-06-27 12:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25 10:01 [LTP] [PATCH] msgstress01: remove TWARN type from runtime remaining Li Wang
2024-06-26 13:39 ` Cyril Hrubis
2024-06-27  2:41   ` Li Wang
2024-06-27  3:14     ` [LTP] [PATCH v2] msgstress01: remove TWARN " Li Wang
2024-06-27 11:40       ` Cyril Hrubis
2024-06-27 11:46         ` Li Wang
2024-06-27 11:47           ` Cyril Hrubis
2024-06-27 11:59             ` Li Wang
2024-06-27 12:04               ` Cyril Hrubis
2024-06-27 12:15                 ` Li Wang
2024-06-27 12:53                   ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zn1gzzTTnm32jeE6@yuki \
    --to=chrubis@suse.cz \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox