From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 09/11] Add statmount04 test
Date: Wed, 10 Jul 2024 16:42:31 +0200 [thread overview]
Message-ID: <Zo6d1-d2FoOBY2km@yuki> (raw)
In-Reply-To: <Zo6aXATzHGRaPt46@yuki>
Hi!
> > +static void cleanup(void)
> > +{
> > + if (tst_is_mounted(DIR_C))
> > + SAFE_UMOUNT(DIR_C);
> > +
> > + if (tst_is_mounted(DIR_B))
> > + SAFE_UMOUNT(DIR_B);
> > +
> > + if (tst_is_mounted(DIR_A))
> > + SAFE_UMOUNT(DIR_A);
>
> Again I wouldn't bet that umounting once is enough here. If my mental
> image is right we have stacked several mounts on each directory.
>
> I wonder how many cycled would this code do?
>
> while (tst_is_mounted(DIR_A))
> SAFE_UMOUNT(DIR_A);
Scratch that, we are bind mounting only once, so it should be correct.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-07-10 14:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 12:29 [LTP] [PATCH v3 00/11] statmount/listmount testing suites Andrea Cervesato
2024-05-16 12:29 ` [LTP] [PATCH v3 01/11] Add SAFE_STATX macro Andrea Cervesato
2024-07-09 6:15 ` Avinesh Kumar
2024-05-16 12:29 ` [LTP] [PATCH v3 02/11] Add listmount/statmount syscalls Andrea Cervesato
2024-07-09 6:15 ` Avinesh Kumar
2024-05-16 12:29 ` [LTP] [PATCH v3 03/11] Add listmount/statmount fallback declarations Andrea Cervesato
2024-07-09 8:06 ` Cyril Hrubis
2024-05-16 12:29 ` [LTP] [PATCH v3 04/11] Add listmount01 test Andrea Cervesato
2024-07-09 8:46 ` Cyril Hrubis
2024-05-16 12:29 ` [LTP] [PATCH v3 05/11] Add listmount02 test Andrea Cervesato
2024-07-09 10:18 ` Cyril Hrubis
2024-05-16 12:29 ` [LTP] [PATCH v3 06/11] Add stamount01 test Andrea Cervesato
2024-07-09 11:15 ` Cyril Hrubis
2024-07-10 8:00 ` Cyril Hrubis
2024-05-16 12:29 ` [LTP] [PATCH v3 07/11] Add statmount02 test Andrea Cervesato
2024-07-10 8:03 ` Cyril Hrubis
2024-05-16 12:29 ` [LTP] [PATCH v3 08/11] Add statmount03 test Andrea Cervesato
2024-07-10 8:18 ` Cyril Hrubis
2024-05-16 12:29 ` [LTP] [PATCH v3 09/11] Add statmount04 test Andrea Cervesato
2024-07-10 14:27 ` Cyril Hrubis
2024-07-10 14:42 ` Cyril Hrubis [this message]
2024-05-16 12:29 ` [LTP] [PATCH v3 10/11] Add statmount05 test Andrea Cervesato
2024-07-10 15:09 ` Cyril Hrubis
2024-05-16 12:29 ` [LTP] [PATCH v3 11/11] Add statmount06 test Andrea Cervesato
2024-07-10 14:55 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zo6d1-d2FoOBY2km@yuki \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox