Re: [LTP] [PATCH v3 11/11] Add statmount06 test

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright (C) 2024 SUSE LLC Andrea Cervesato <andrea.cervesato@suse.com>
> + */
> +
> +/*\
> + * [Description]
> + *
> + * This test verifies that statmount() is correctly reading name of the
> + * filesystem type using STATMOUNT_FS_TYPE.
> + *
> + * [Algorithm]
> + *
> + * * create a mount point
> + * * run statmount() on the mount point using STATMOUNT_FS_TYPE
> + * * read results and check if contain the name of the filesystem
> + */
> +
> +#include "statmount.h"
> +#include "lapi/stat.h"
> +#include "lapi/sched.h"
> +
> +#define MNTPOINT "mntpoint"
> +#define SM_SIZE (1 << 10)
> +
> +static uint64_t root_id;
> +static struct statmount *st_mount;
> +
> +static void run(void)
> +{
> +	memset(st_mount, 0, SM_SIZE);
> +
> +	TST_EXP_PASS(statmount(
> +		root_id,
> +		STATMOUNT_FS_TYPE,
> +		st_mount,
> +		SM_SIZE,
> +		0));
> +
> +	if (TST_RET == -1)
> +		return;
> +
> +	TST_EXP_EQ_LI(st_mount->mask, STATMOUNT_FS_TYPE);
> +	TST_EXP_EXPR(strcmp(st_mount->str + st_mount->fs_type, tst_device->fs_type) == 0,
> +		"statmount() read '%s', expected '%s'",
> +		st_mount->str + st_mount->fs_type, tst_device->fs_type);

This starts to be a common pattern, I guess that we need TST_EXP_STR_EQ()...

> +}
> +
> +static void setup(void)
> +{
> +	struct statx sx;
> +
> +	SAFE_STATX(AT_FDCWD, MNTPOINT, 0, STATX_MNT_ID_UNIQUE, &sx);
> +	root_id = sx.stx_mnt_id;
> +}
> +
> +static struct tst_test test = {
> +	.test_all = run,
> +	.setup = setup,
> +	.min_kver = "6.8",
> +	.mount_device = 1,
> +	.mntpoint = MNTPOINT,
> +	.all_filesystems = 1,
> +	.skip_filesystems = (const char *const []) {
> +		"fuse",
> +		NULL
> +	},
> +	.bufs = (struct tst_buffers []) {
> +		{&st_mount, .size = SM_SIZE},
> +		{}
> +	}
> +};
> 
> -- 
> 2.35.3
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp