public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v5] Add stat04 test
Date: Tue, 2 Jul 2024 15:26:19 +0200	[thread overview]
Message-ID: <ZoP_-6z9LPTn8Yac@yuki> (raw)
In-Reply-To: <9b70179d-2bfa-47e3-8ae3-5cbb971bd5c3@suse.com>

Hi!
> This test is basically a clone of the lstat03 test. I'm wondering if it 
> makes sense to have both, when we already have that one.

You are stil missing the point of this test, the end result we expect is
different for stat() and lstat(). The point I'm trying to make is that
we should:

1. Make sure that as many attributes are diffent for the symlink and the
   symlink target for *both* stat() and lstat() tests, since if they are
   not made different the test does results are not conclusive at all

2. For stat() you should get same result on the file and symlink since
   stat actually follows the symlink then gets the data

3. For lstat() you should get different result on the file and symlink
   since lstat() *does not* follow the symlink before it gets the data

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-07-02 13:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-17 14:44 [LTP] [PATCH v5] Add stat04 test Andrea Cervesato
2024-06-24 12:22 ` Cyril Hrubis
2024-07-02 13:10   ` Andrea Cervesato via ltp
2024-07-02 13:26     ` Cyril Hrubis [this message]
2024-07-02 13:30       ` Andrea Cervesato via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZoP_-6z9LPTn8Yac@yuki \
    --to=chrubis@suse.cz \
    --cc=andrea.cervesato@suse.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox