From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] Add mseal01 test
Date: Thu, 11 Jul 2024 17:53:20 +0200 [thread overview]
Message-ID: <Zo__8L2e_0hHH5of@yuki> (raw)
In-Reply-To: <20240610-mseal-v1-2-f659b9e97efa@suse.com>
Hi!
> +#ifndef TST_ABI32
This is the worst type of check you can do and should be used only when
the test code does not compile at all.
Instead you should check the return value from mseal() syscall and TCONF
if you get ENOSYS on 32bit, at least the syscalls numbers seems to be
allocated so you should get ENOSYS at runtime.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-07-11 15:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 9:43 [LTP] [PATCH 0/2] Add mseal() testing suite Andrea Cervesato
2024-06-10 9:44 ` [LTP] [PATCH 1/2] Add mseal() syscall declaration Andrea Cervesato
2024-06-10 9:44 ` [LTP] [PATCH 2/2] Add mseal01 test Andrea Cervesato
2024-07-11 15:53 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zo__8L2e_0hHH5of@yuki \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox