Re: [LTP] [PATCH 1/5] Add stat04 test

Cyril Hrubis
2024-07-04T11:56:23Z

Hi!
> > And if you are asking if the test will run fine without the sleep, it
> > will run and it will pass, but the timestamps will be same for the link
> > and the file, so if kernel picks up wrong timestamp we will not find
> > out.
> >
>
> I'm confused, do you mean if the kernel sets a wrong timestamp it could
> report TFAIL?
>
> From what I can tell, the stat(sym_path,) also retrieves information of
> the target file,
> shouldn't that always equal the stat(file_path,) timestamp? As long as the
> stat()
> works correctly, with sleep(1) or not won't impact anything.

The test tries to assert that stat() follows the symlink and this test
is a unit test for this assertion. However if we do not spend some
effort on making the link and target attributes actually diffferent the
test would pass even if kernel returned the attributes for the symlink
instead.

--
Cyril Hrubis
chrubis@suse.cz