public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: Martin Doucha <martin.doucha@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 5/6] runtest/sched: Add sched_football
Date: Mon, 29 Jul 2024 11:47:16 +0200	[thread overview]
Message-ID: <ZqdlJJ1-AYAJsDcL@yuki> (raw)
In-Reply-To: <20240729073226.GA1223191@pevik>

Hi!
> > diff --git a/runtest/sched b/runtest/sched
> > index 5dab7a4c27..ecedd1a92b 100644
> > --- a/runtest/sched
> > +++ b/runtest/sched
> > @@ -18,3 +18,5 @@ sched_cli_serv run_sched_cliserv.sh
> >  sched_stress sched_stress.sh
> 
> >  autogroup01 autogroup01
> > +
> > +sched_football sched_football
> 
> I'm sorry, I haven't noticed, that realtime installs into a different directory:

Uff, missed that as well. The INSTALL_DIR is set in the config.mk for
the realtime tests to $(srcdir) so it copies the layout of the realtime
directories.

> cd ltp/testcases/realtime/func/sched_football
> # make install
> mkdir -p "/opt/ltp/testcases/realtime/func/sched_football"
> install -m 00775   "ltp/testcases/realtime/func/sched_football/run_auto.sh" /opt/ltp/testcases/realtime/func/sched_football/run_auto.sh
> install -m 00775   "ltp/testcases/realtime/func/sched_football/sched_football" /opt/ltp/testcases/realtime/func/sched_football/sched_football

The minimal fix would be to overwrite the INSTALL_DIR for the
sched_football testcase, that would be:

diff --git a/testcases/realtime/func/sched_football/Makefile b/testcases/realtime/func/sched_football/Makefile
index 9bc779efa..aac98eab6 100644
--- a/testcases/realtime/func/sched_football/Makefile
+++ b/testcases/realtime/func/sched_football/Makefile
@@ -6,10 +6,11 @@

 top_srcdir             ?= ../../../..

-INSTALL_TARGETS                := run_auto.sh
 include $(top_srcdir)/include/mk/env_pre.mk
 include $(abs_srcdir)/../../config.mk

+INSTALL_DIR=testcases/bin
+
 # TODO: integrate properly with LTP library
 LDLIBS                 += -lltp
 include $(top_srcdir)/include/mk/generic_leaf_target.mk


We can move the source code around once we get to the realtime directory
cleanup later on.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-07-29  9:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-17 17:17 [LTP] [PATCH 0/6] sched_football in runtest/sched + configure cleanup Petr Vorel
2024-07-17 17:17 ` [LTP] [PATCH 1/6] configure: Print info about TI-RPC testsuite in summary Petr Vorel
2024-07-17 17:17 ` [LTP] [PATCH 2/6] configure: Don't assume testcases/realtime/configure.ac Petr Vorel
2024-07-17 17:17 ` [LTP] [PATCH 3/6] configure: Print info about KVM testsuite in summary Petr Vorel
2024-07-17 17:17 ` [LTP] [PATCH 4/6] configure: Enable realtime testsuite by default Petr Vorel
2024-07-17 17:17 ` [LTP] [PATCH 5/6] runtest/sched: Add sched_football Petr Vorel
2024-07-29  7:32   ` Petr Vorel
2024-07-29  9:47     ` Cyril Hrubis [this message]
2024-07-29 11:41       ` Petr Vorel
2024-07-17 17:17 ` [LTP] [PATCH 6/6] realtime: Use proper syntax for non-system include Petr Vorel
2024-07-18  8:22 ` [LTP] [PATCH 0/6] sched_football in runtest/sched + configure cleanup Cyril Hrubis
2024-07-18 10:29 ` Li Wang
2024-07-26 10:09   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZqdlJJ1-AYAJsDcL@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=martin.doucha@suse.com \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox