From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/1] cachestat01: Reduce required space on 64kb page size
Date: Wed, 31 Jul 2024 12:39:36 +0200 [thread overview]
Message-ID: <ZqoUaJ4sc30EHzNm@yuki> (raw)
In-Reply-To: <ZqoSvzmu3vmJugC7@yuki>
Hi!
> > + num_shift = MIN(tst_device->size*1024*2.6/page_size, 15);
>
> I guess that we can make it future proof by rounding the 2.6 to 3 just
And that is on the wrong side obviously, so we should do rounding down
to 2 or 2.2 or something along the lines.
> to avoid failures in the future when filesystems consume just a bit more
> space for a metadata...
>
> Other than that:
>
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
>
> > page_data = SAFE_MALLOC(page_size);
> > memset(page_data, 'a', page_size);
> > }
> > --
> > 2.45.2
> >
>
> --
> Cyril Hrubis
> chrubis@suse.cz
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-07-31 10:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 7:34 [LTP] [PATCH v2 1/1] cachestat01: Reduce required space on 64kb page size Petr Vorel
2024-07-31 10:32 ` Cyril Hrubis
2024-07-31 10:39 ` Cyril Hrubis [this message]
2024-07-31 19:30 ` Petr Vorel
2024-08-01 9:00 ` Cyril Hrubis
2024-08-01 9:14 ` Petr Vorel
2024-10-18 7:50 ` Hongchen Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqoUaJ4sc30EHzNm@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox