Re: [LTP] [PATCH] mseal01: handle more possible errnos when pkey_alloc gets fail

Li Wang
2024-08-05T06:41:33Z

On Mon, Aug 5, 2024 at 2:38 PM Andrea Cervesato via ltp <ltp@lists.linux.it>
wrote:

> Hi!
>
> Thanks for helping on mseal01. I already submitted the patch, but we can
> apply a new patch on top of it without problems.
> Review below
>
> On 8/3/24 14:22, Li Wang wrote:
> > Signed-off-by: Li Wang <liwang@redhat.com>
> > ---
> > testcases/kernel/syscalls/mseal/mseal01.c | 16 +++++-----------
> > 1 file changed, 5 insertions(+), 11 deletions(-)
> >
> > diff --git a/testcases/kernel/syscalls/mseal/mseal01.c
> b/testcases/kernel/syscalls/mseal/mseal01.c
> > index eb2f4d588..2ff6ed119 100644
> > --- a/testcases/kernel/syscalls/mseal/mseal01.c
> > +++ b/testcases/kernel/syscalls/mseal/mseal01.c
> > @@ -25,6 +25,7 @@
> >
> > #include "tst_test.h"
> > #include "lapi/syscalls.h"
> > +#include "../pkeys/pkey.h"
> The problem with this approach is that testing suites won't be
> independent anymore.
> We need to move all pkeys/pkey.h declarations inside the lapi/ folder,
> in order to use pkey syscalls from any testing suite.
>

Sure, I will update my patch to include that. Thanks!

--
Regards,
Li Wang