From: Wei Gao via ltp <ltp@lists.linux.it>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/1] isofs.sh: Use nobody user
Date: Mon, 2 Sep 2024 04:00:39 -0400 [thread overview]
Message-ID: <ZtVwp4i6tuwDN7sJ@wegao> (raw)
In-Reply-To: <20240902071615.GA279460@pevik>
On Mon, Sep 02, 2024 at 09:16:15AM +0200, Petr Vorel wrote:
> Hi Wei,
>
> > > +TEST_USER='nobody'
> > > +
> > > +setup()
> > > +{
> > > + TEST_GROUP="$(id -g -n $TEST_USER)"
> > > + [ "$TEST_GROUP" ] || TEST_GROUP="$TEST_USER"
> > If $TEST_GROUP can not be found then this case will failed unless we create new group.
> > My suggestion is remove above line totally or we start create group for nobody user.
>
> That check is a fallback if 'id' is not installed but there is requested
> nobody:nobody or nobody/nogroup group set by IDcheck.sh or manually.
Thanks for your explaination. Then no question from my side.
Acked-by: Wei Gao <wegao@suse.com>
>
> But sure, I can delete it if we expect id to be installed. I just did not want
> to require 'id' for this test when there can be a workaround.
>
> Kind regards,
> Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-09-02 8:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 6:27 [LTP] [PATCH v2 1/1] isofs.sh: Use nobody user Petr Vorel
2024-09-02 6:51 ` Wei Gao via ltp
2024-09-02 7:16 ` Petr Vorel
2024-09-02 8:00 ` Wei Gao via ltp [this message]
2024-09-03 10:06 ` Cyril Hrubis
2024-09-03 12:47 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtVwp4i6tuwDN7sJ@wegao \
--to=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox