Re: [LTP] [PATCH v1] mpls01.sh: Add --allow-unsupported for modprobe

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> I'm not sure with ROD.  --allow-unsupported is SUSE specific modprobe extension,
> which is used for SLES.  It is also on Tumbleweed [1] [2] where does nothing.
> 
> If you try to run it with ROD, which quits testing on failure, all distros
> except SUSE products/openSUSE (e.g. Debian, Fedora, ...) which don't have
> mpls_router will TBROK in setup:
> 
> 	modprobe: unrecognised option '--allow-unsupported'.
> 
> And I'm not talking about these small distros which use busybox kmod
> implementation, which would also fail.
> 
> Also you remove /dev/null 2>&1 from the first command, thus other distros would
> not see error message about missing mpls_router module. Without looking into the
> source the tester will be pretty confused.
> 
> I would do:
> 
> 	if grep -q suse /etc/os-release; then

There are a couple of english words that contain "suse" as a substring
if one of these ends up in the os-release it would match, e.g. the
os-release may contain VERSION="24 (Disused Miracle)".  And yes both
Fedora and Ubuntu seems to include the the code names in the file.

So I would be stricter here and checked for ID=suse.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp