public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] mpls01.sh: Add --allow-unsupported for modprobe
Date: Tue, 3 Sep 2024 12:16:06 +0200	[thread overview]
Message-ID: <Ztbh5qyDln_t5C18@yuki.lan> (raw)
In-Reply-To: <20240903081916.27033-1-wegao@suse.com>

Hi!
> Signed-off-by: Wei Gao <wegao@suse.com>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> ---
>  testcases/network/mpls/mpls01.sh | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/testcases/network/mpls/mpls01.sh b/testcases/network/mpls/mpls01.sh
> index 196b5b2f9..892b5bd85 100755
> --- a/testcases/network/mpls/mpls01.sh
> +++ b/testcases/network/mpls/mpls01.sh
> @@ -21,7 +21,11 @@ cleanup()
>  
>  setup()
>  {
> -	ROD modprobe mpls_router
> +	if grep -q 'sl-micro' /etc/os-release; then

I do not like how specific is this check. The --allow-unsupported should
be at best no-op for SLE and openSUSE, right? So I would go for the
check of ID=suse rather than specifying just single variant.

> +		ROD modprobe --allow-unsupported mpls_router
> +	else
> +		ROD modprobe mpls_router
> +	fi
>  }
>  
>  test1()
> -- 
> 2.35.3
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2024-09-03 10:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30  9:57 [LTP] [PATCH v1] mpls01.sh: Add --allow-unsupported for modprobe Wei Gao via ltp
2024-08-30 10:38 ` Petr Vorel
2024-09-02 10:39   ` Cyril Hrubis
2024-09-02 11:00     ` Petr Vorel
2024-09-02  2:40 ` [LTP] [PATCH v2] " Wei Gao via ltp
2024-09-02 11:02   ` Petr Vorel
2024-09-03  8:19   ` [LTP] [PATCH v3] " Wei Gao via ltp
2024-09-03  9:49     ` Petr Vorel
2024-09-03 10:16     ` Cyril Hrubis [this message]
2024-09-03 11:26       ` Petr Vorel
2024-09-04  3:58     ` [LTP] [PATCH v4] " Wei Gao via ltp
2024-09-04  4:47       ` Petr Vorel
2024-09-04  6:50         ` Wei Gao via ltp
2024-09-04  6:48       ` [LTP] [PATCH v5] " Wei Gao via ltp
2024-09-04  6:56         ` [LTP] [PATCH v6] mpls01: Add --allow-unsupported for modprobe(fixing all mpls cases) Wei Gao via ltp
2024-09-05  5:12           ` Petr Vorel
2024-09-05  8:47             ` Cyril Hrubis
2024-09-05 12:02               ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ztbh5qyDln_t5C18@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=wegao@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox