Re: [LTP] [PATCH v4] mpls01.sh: Add --allow-unsupported for modprobe

[Wei Gao via ltp <ltp@lists.linux.it>]

On Wed, Sep 04, 2024 at 06:47:10AM +0200, Petr Vorel wrote:
> Hi Wei,
> 
> I suggest these changes:
> 
> 1) use mpls_setup_driver also in mpls_setup()
> - replace tst_net_run(). I don't understand why you did not do it in the
>   patchset (I suggested that), but I can replace it during merge.
Sorry i forget that, will sent another patch. Thanks for point that.
> 2) update the commit message: s/mpls01.sh/mpls01/
>    (fixing all mpls tests)
> 
> With that:
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
> Kind regards,
> Petr
> 
> +++ testcases/network/mpls/mpls_lib.sh
> @@ -47,7 +47,7 @@ mpls_setup()
>  {
>  	local label="$1"
>  
> -	tst_net_run -s "modprobe -a $TST_NEEDS_DRIVERS"
> +	mpls_setup_driver
>  
>  	ROD sysctl -q net.mpls.conf.$(tst_iface).input=1
>  	tst_set_sysctl net.mpls.conf.lo.input 1 safe

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp