public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 2/4] Add support for mixing C and shell code
Date: Fri, 6 Sep 2024 15:28:37 +0200	[thread overview]
Message-ID: <ZtsDheQySS4co49v@yuki.lan> (raw)
In-Reply-To: <ZtrmCfp5dPTx6vk_@yuki.lan>

Hi!
> The difference is that /bin/sh links to dash in debian. But as you
> pointed out even if all /bin/sh is changed to /bin/bash in the scripts
> the tests stil fails.
> 
> It looks like on RPi alias with variables does not work at all.

So it looks like aliases may not be expanded on non-interactive shells
unless it's enabled explicitely.

This patch uses shopt to enable that and also works around dash that
does not support $LINENO:

diff --git a/testcases/lib/tst_env.sh b/testcases/lib/tst_env.sh
index 67ba80744..bb0c586d7 100644
--- a/testcases/lib/tst_env.sh
+++ b/testcases/lib/tst_env.sh
@@ -6,6 +6,16 @@
 
 tst_script_name=$(basename $0)
 
+# bash does not expand aliases in non-iteractive mode, enable it
+if [ -n "$BASH_VERSION" ]; then
+       shopt -s expand_aliases
+fi
+
+# dash does not support line numbers even though this is mandated by POSIX
+if [ -z "$LINENO" ]; then
+       LINENO=-1
+fi
+
 if [ -z "$LTP_IPC_PATH" ]; then
        echo "This script has to be executed from a LTP loader!"
        exit 1


-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-09-06 13:30 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-27 12:02 [LTP] [PATCH v3 0/4] Shell test library v3 Cyril Hrubis
2024-08-27 12:02 ` [LTP] [PATCH v3 1/4] include: tst_clone.h: Fix possible MUSL build failures Cyril Hrubis
2024-09-03  7:46   ` Petr Vorel
2024-09-03  8:02     ` Cyril Hrubis
2024-08-27 12:02 ` [LTP] [PATCH v3 2/4] Add support for mixing C and shell code Cyril Hrubis
2024-08-30 12:40   ` Andrea Cervesato via ltp
2024-09-03  7:29   ` Li Wang
2024-09-03  8:24   ` Petr Vorel
2024-09-16  9:52     ` Cyril Hrubis
2024-09-06  7:34   ` Li Wang
2024-09-06  9:53     ` Cyril Hrubis
2024-09-06 10:03       ` Cyril Hrubis
2024-09-06 10:09       ` Li Wang
2024-09-06 11:22         ` Cyril Hrubis
2024-09-06 13:28           ` Cyril Hrubis [this message]
2024-09-07  1:29             ` Li Wang
2024-09-06 10:19       ` Li Wang
2024-09-06 11:06         ` Li Wang
2024-08-27 12:02 ` [LTP] [PATCH v3 3/4] libs: Vendor ujson library Cyril Hrubis
2024-08-30 12:41   ` Andrea Cervesato via ltp
2024-09-16  9:58     ` Cyril Hrubis
2024-08-27 12:02 ` [LTP] [PATCH v3 4/4] testcaes/lib: Add shell loader Cyril Hrubis
2024-08-30 12:47   ` Andrea Cervesato via ltp
2024-09-16 10:04     ` Cyril Hrubis
2024-08-30 12:50   ` Andrea Cervesato via ltp
2024-09-16 10:02     ` Cyril Hrubis
2024-09-09  9:03   ` Li Wang
2024-09-16 10:08 ` [LTP] [PATCH v3 0/4] Shell test library v3 Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZtsDheQySS4co49v@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox